Alembic: fix crash when trying to read from an invalid ICompoundProperty
AbandonedPublic
Actions

Authored by Kévin Dietrich (kevindietrich) on May 31 2021, 4:33 PM.

Details

Reviewers

Summary

read_generated_coordinates does not verify the validity of the input ICompoundProperty,
which can lead to crashes when an IObject does not have any arbitrary geometry parameters.

Diff Detail

Repository

rB Blender

Branch

abc_fix_genco_crash (branched from master)

Build Status

Buildable 14857
Build 14857: arc lint + arc unit

Event Timeline

Kévin Dietrich (kevindietrich) requested review of this revision.May 31 2021, 4:33 PM

Kévin Dietrich (kevindietrich) created this revision.

Harbormaster completed remote builds in B14857: Diff 37654.May 31 2021, 4:33 PM

I already submitted this in D11408: Fix T88605: alembic import crash for meshes without arbGeomParams

I quickly looked if a patch was already sent for this one, but I missed it apparently, closing this one. Thanks for letting me know.

Revision Contents
Changeset List

Path

Size

source/

blender/

io/

alembic/

intern/

abc_customdata.cc

4 lines

Diff 37654

View Options

source/blender/io/alembic/intern/abc_customdata.cc

Alembic: fix crash when trying to read from an invalid ICompoundPropertyAbandonedPublicActions