FFmpeg: Update proxy settings
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Jun 1 2021, 10:39 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rB00ffe028200a: FFmpeg: Update proxy settings
rBa9dfde7b49eb: FFmpeg: Update proxy settings

Summary

Changes in rBce649c73446e, affected established proxy codec preset.
Presets were not working and all presets were similar to veryfast.
Tunes are now working too, so fastdecode tune can be used. I have
measured little improvement, but I tested this only on 2 machines and
I have been informed that fastdecode tune does influence decoding
performance for some users.

Change preset from slow to veryfast and add tune fastdecode

Diff Detail

Repository

rB Blender

Branch

proxy-preset (branched from master)

Build Status

Buildable 14883
Build 14883: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Jun 1 2021, 10:39 PM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B14883: Diff 37704.Jun 1 2021, 10:39 PM

Does it affect the file size? Proxy build time?

source/blender/imbuf/intern/indexer.c
538	The comment needs to be updated.

This revision is now accepted and ready to land.Jun 2 2021, 9:37 AM

Sorry, didn't want to change the review state, happened by accident :(

This revision now requires changes to proceed.Jun 2 2021, 9:37 AM

Add more elaborative comment.

Harbormaster completed remote builds in B14896: Diff 37726.Jun 2 2021, 2:46 PM

Sergey Sharybin (sergey) accepted this revision.Jun 2 2021, 2:48 PM

This revision is now accepted and ready to land.Jun 2 2021, 2:48 PM

Damn those inlines not submitting sometimes...

source/blender/imbuf/intern/indexer.c
538	Technically comment is still true. Veryfast preset in many instances gives best result in respect to filesize. This has been revealed by my own tests and independently here https://write.corbpie.com/ffmpeg-preset-comparison-x264-2019-encode-speed-and-file-size/ I will rephrase comment though.

@Richard Antalik (ISS) Hopefully it has been fixed with ffmpeg update, but I remember talk about Macs having problems with fastdecode, so maybe you should ask someone from the BF team to check the patch on a Mac?

Closed by commit rBa9dfde7b49eb: FFmpeg: Update proxy settings (authored by Richard Antalik (ISS)). · Explain WhyJun 2 2021, 9:44 PM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rBa9dfde7b49eb: FFmpeg: Update proxy settings.

Jeroen Bakker (jbakker) added a commit: rB00ffe028200a: FFmpeg: Update proxy settings.Jun 30 2021, 9:48 AM