Page MenuHome

Fix T88785: Avoid value slider clipping through rounded corners
ClosedPublic

Authored by Leon Schittek (lone_noel) on Jun 3 2021, 2:19 PM.

Details

Summary

Avoid the value slider clipping through rounded corners for low values
by ensuring the width of the slider rectangle is at least twice the
corner radius.


When the slider rectangle width got lower than twice the corner radius,
the shader gpu_shader_2D_widget_base_frag.glsl partially cut off the
rounded corners, because it sections the rounded rectangle in
quadrants.

This patch fixes this by ensuring that the slider rectangle always has a
width of at least twice the corner radius.

masterpatch2.83

Diff Detail

Repository
rB Blender

Event Timeline

Leon Schittek (lone_noel) requested review of this revision.Jun 3 2021, 2:19 PM
Leon Schittek (lone_noel) created this revision.

Update to current state of master.

Update to current state of master.

Leon Schittek (lone_noel) updated this revision to Diff 47719.EditedJan 29 2022, 5:41 PM

Update to current state of master.

Update to current state of master.

Update to current state of master.

As long as you've checked this with different roundness levels, and different region and UI zoom levels, the change looks reasonable. Thanks for looking into it.

This revision is now accepted and ready to land.Mar 31 2022, 9:58 PM