Cycles X: first step to restore baking support
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Jun 3 2021, 6:24 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rBe2856c85e45d: Cycles X: first step to restore baking support

Summary

Minimal changes to get the baking pipeline operational, only bakes the Combined
pass.

Add integrator_init_from_bake kernel, that reads the primitive and uv from the render passes and sets up data structures for shade_surface.
Add back support for reading render passes from Blender.

Since this reuses most of the path tracing code, baking now works with OptiX,
adaptive sampling and denoising.

Diff Detail

Repository: rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Jun 3 2021, 6:24 PM

Brecht Van Lommel (brecht) created this revision.

Harbormaster completed remote builds in B14930: Diff 37814.Jun 3 2021, 6:24 PM

Fran Marz (franMarz) awarded a token.Jun 3 2021, 6:52 PM

Alaska (Alaska) awarded a token.Jun 4 2021, 1:21 AM

The PassAccessor part would need to be updated for the changes from yesterday.

For the rest the code seems fine.
There is one thing about the shadow catchers: we should ignore the shadow catcher visibility when baking. Not sure if it happens already.

Update for pass accessor changes.

Harbormaster completed remote builds in B14969: Diff 37871.Jun 4 2021, 3:57 PM

Sergey Sharybin (sergey) accepted this revision.Jun 7 2021, 11:19 AM

This revision is now accepted and ready to land.Jun 7 2021, 11:19 AM

Closed by commit rBe2856c85e45d: Cycles X: first step to restore baking support (authored by Brecht Van Lommel (brecht)). · Explain WhyJun 7 2021, 6:40 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBe2856c85e45d: Cycles X: first step to restore baking support.

Once before Brecht you mentioned in another task on here that it wouldn't take long to add a few more baking outputs to blender's baking system, since you're currently working on re-implementing baking for Cycles X, I hope you don't mind if I ask, are you planning to add any extra outputs for baking while you're at it? Would the changes for Cycles X make those easier or harder now?

Such as the main inputs of the Principled BSDF: Base Colour, Specular, Metallic?

Mindinsomnia (mindinsomnia) awarded a token.Jun 16 2021, 7:35 AM