Page MenuHome
Differential D11486

Build: upgrade OpenImageDenoise to 1.4.0
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Jun 3 2021, 6:30 PM.

Details

Reviewers
Sebastián Barschkis (sebbas)
Sybren A. Stüvel (sybren)
Ray Molenkamp (LazyDodo)
Bastien Montagne (mont29)
Maniphest Tasks
T88434: OpenImageDenoise 1.4 upgrade
T88438: Libraries Changes for Blender 3.0
Commits
rB8bd09b1d77a3: Build: upgrade OpenImageDenoise to 1.4.0
Summary

Ref T88438, T88434

Diff Detail

Repository
rB Blender
Branch
oidn-1.4 (branched from master)
Build Status
Buildable 14931
Build 14931: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Jun 3 2021, 6:30 PM
Brecht Van Lommel (brecht) created this revision.
Harbormaster completed remote builds in B14931: Diff 37815.Jun 3 2021, 6:31 PM
Brecht Van Lommel (brecht) added inline comments.Jun 3 2021, 6:32 PM
build_files/build_environment/patches/oidn.diff
20–27

This part of the patch is no longer needed since it's already fixed upstream.

Brecht Van Lommel (brecht) added a subscriber: Sergey Sharybin (sergey).Jun 3 2021, 6:33 PM
Ray Molenkamp (LazyDodo) added a comment.Jun 3 2021, 7:59 PM

the arm commit broke some things on windows, i'd like to have the current lib building again before adding/changing other libraries, we may not need a patch for oidn at all, but i'm gonna need a few days to know for sure.

Alaska (Alaska) awarded a token.Jun 4 2021, 1:23 AM
HEYPictures (HEYPictures) awarded a token.Jun 4 2021, 8:24 AM
Brecht Van Lommel (brecht) added a comment.Jun 4 2021, 3:06 PM

That's fine, I can wait.

Ray Molenkamp (LazyDodo) requested changes to this revision.Jun 4 2021, 5:21 PM

TBB Fixes are in, any patches to oidn's /cmake/FindTBB.cmake are no longer required.

This revision now requires changes to proceed.Jun 4 2021, 5:21 PM
Brecht Van Lommel (brecht) updated this revision to Diff 37879.Jun 4 2021, 5:36 PM

Remove Windows TBB patches.

Harbormaster completed remote builds in B14974: Diff 37879.Jun 4 2021, 5:36 PM
Ray Molenkamp (LazyDodo) accepted this revision.Jun 4 2021, 5:57 PM
This revision is now accepted and ready to land.Jun 4 2021, 5:57 PM
kursad k (kursadk) awarded a token.Jun 5 2021, 7:24 AM
Ray Molenkamp (LazyDodo) mentioned this in T88438: Libraries Changes for Blender 3.0.Jun 8 2021, 4:23 PM
Bastien Montagne (mont29) accepted this revision.Jun 8 2021, 4:44 PM
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).

Assuming ISPC version update is not needed then?

Otherwise patch LGTM on install_deps side.

Brecht Van Lommel (brecht) added a comment.Jun 8 2021, 5:00 PM

No ISPC upgrade is needed indeed.

Brecht Van Lommel (brecht) added a comment.Jun 8 2021, 6:42 PM

This compiles on Linux and macOS here, so I assume this is ok to commit.

Closed by commit rB8bd09b1d77a3: Build: upgrade OpenImageDenoise to 1.4.0 (authored by Brecht Van Lommel (brecht)). · Explain WhyJun 8 2021, 7:24 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB8bd09b1d77a3: Build: upgrade OpenImageDenoise to 1.4.0.
Ray Molenkamp (LazyDodo) added a comment.Jun 8 2021, 10:21 PM

Landing this made one of the compositor tests fail with minor differences, probably just needs an update.

Revision Contents
Changeset List

PathSize
build_files/
build_environment/
cmake/
4 lines
8 lines
patches/
25 lines

Diff 37815

View Options

build_files/build_environment/cmake/versions.cmake

Loading...
View Options

build_files/build_environment/install_deps.sh

Loading...
View Options

build_files/build_environment/patches/oidn.diff

Loading...