Texture Paint: changing paint slots and viewport could go out of sync
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jun 4 2021, 10:12 AM.

Details

Reviewers

Campbell Barton (campbellbarton)
Germano Cavalcante (mano-wii)

Maniphest Tasks

T88788: When selected a texture in the Properties panel shows another texture in the 3D Viewport.

Commits

rBd354e6a84688: Texture Paint: changing paint slots and viewport could go out of sync
rB56005ef49989: Texture Paint: changing paint slots and viewport could go out of sync

Summary

When changing to another texture paint slot, the texture displayed in
the viewport should change accordingly (as well as the image displayed
in the Image Editor).

The procedure to find the texture to display in the viewport
(BKE_texpaint_slot_material_find_node) could fail
though because it assumed iterating nodes would always happen in the
same order (it was index based). This is not the case though, nodes can
get sorted differently based on selection (see ED_node_sort).

Now check the actual image being referenced in the paint slot for
comparison.

ref T88788 (probably enough to call this a fix, the other issue(s)
mentioned in the report are more likely a feature request)

Diff Detail

Repository

rB Blender

Branch

T88788_a (branched from master)

Build Status

Buildable 14959
Build 14959: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Jun 4 2021, 10:12 AM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B14959: Diff 37852.Jun 4 2021, 10:12 AM

Philipp Oeser (lichtwerk) added a project: Sculpt, Paint & Texture.Jun 4 2021, 10:12 AM

Bulat (BulatKR) awarded a token.Jun 4 2021, 10:23 AM

Philipp Oeser (lichtwerk) mentioned this in D11497: Texture Paint: sync changing active texture in the node editor to the active paint slot.Jun 4 2021, 10:26 AM

Philipp Oeser (lichtwerk) mentioned this in D11498: Texture Paint: sync changing active texture in the Node Editor to the Image Editor.Jun 4 2021, 10:38 AM

Sounds good, and more reliable than looking for an index that may have been changed.
(I'm not familiar with this area however).

This revision is now accepted and ready to land.Jun 4 2021, 1:00 PM

In D11496#294237, @Germano Cavalcante (mano-wii) wrote:

(I'm not familiar with this area however).

was adding you here since you made rBbc42092a7ddb: Fix T67597: Texture painting: Texture slots that correspond to nodes inside…, but yeah, code is more from rBf745564e4ee7: GSOC 2013 paint

I totally forgot that patch! (I'm concerned about my mental health).
Since I was the one who messed with this, this is another reason to trust in the patch. +1

Campbell Barton (campbellbarton) accepted this revision.Jun 4 2021, 4:09 PM

Closed by commit rB56005ef49989: Texture Paint: changing paint slots and viewport could go out of sync (authored by Philipp Oeser (lichtwerk)). · Explain WhyJun 4 2021, 4:15 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB56005ef49989: Texture Paint: changing paint slots and viewport could go out of sync.

Jeroen Bakker (jbakker) added a commit: rBd354e6a84688: Texture Paint: changing paint slots and viewport could go out of sync.Jun 9 2021, 8:56 AM

Philipp Oeser (lichtwerk) mentioned this in rB3b2a01edf698: Texture Paint: sync changing active texture in the node editor to the.Aug 31 2021, 12:31 PM

Philipp Oeser (lichtwerk) mentioned this in rBb0cb0a785475: Texture Paint: sync changing active texture in the Node Editor to the.Aug 31 2021, 12:48 PM

Philipp Oeser (lichtwerk) mentioned this in D12540: Texture Paint: more Editor syncing.Sep 17 2021, 3:34 PM