Paths

Table of Contentst

BGE : Cleanup camera and font list
AbandonedPublic
Actions

Authored by Porteries Tristan (panzergame) on Feb 28 2015, 11:21 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Sybren A. Stüvel (sybren)
Jorge Bernal (lordloki)
Dalai Felinto (dfelinto)
Mitchell Stokes (moguri)

Summary

I replaced std::list used for cameras and fonts by CListValue, so i removed AddFCamera, FindCamera, AddFont, FindFont functions.
I took advantage of CListValue and add a python attribute for fonts :

KX_Scene.fonts

Diff Detail

Repository: rB Blender
Branch: ge_cleanup_camera_font_list

Event Timeline

Porteries Tristan (panzergame) updated this revision to Diff 3654.Feb 28 2015, 11:21 PM

Porteries Tristan (panzergame) retitled this revision from to BGE : Cleanup camera and font list.

Porteries Tristan (panzergame) added reviewers: Mitchell Stokes (moguri), Campbell Barton (campbellbarton), Dalai Felinto (dfelinto), Sybren A. Stüvel (sybren).

Porteries Tristan (panzergame) updated this object.

What problem does this solve?

It's just a cleanup for devs, all other listes in scene use CListValue i think cameras and fonts don't need to use a std::list there are no advantages.

Porteries Tristan (panzergame) edited edge metadata.Mar 1 2015, 4:17 PM

Porteries Tristan (panzergame) added a project: Game Engine.

Replace i by cam_idx in loop.

Looks good to me. Some things became more complex (scene->FindCamera(name) became (KX_Camera*)scene->GetCameraList()->FindValue(name)) but I feel that the improvement in consistency is worth it.

This revision is now accepted and ready to land.Mar 13 2015, 8:41 PM

Sybren A. Stüvel (sybren) mentioned this in D1153: BGE : Fix T36061; Use of CListValue for scene list in KX_KetsjiEngine.Mar 13 2015, 9:00 PM

Update to the current trunk.

Looks good to me

Only I miss the doc for new fonts attribute (bge_types/bge.types.KX_Scene.rst).

Other than this, looks good to me.

This revision now requires changes to proceed.Apr 5 2015, 2:32 AM

Add documentation and fix mouse sensor

Jorge Bernal (lordloki) accepted this revision.Apr 6 2015, 6:37 AM

Jorge Bernal (lordloki) edited edge metadata.

This revision is now accepted and ready to land.Apr 6 2015, 6:37 AM

I'm not yet sure if I like these changes, so I'm blocking this revision until I can find time to look over it in detail.

This revision now requires changes to proceed.Apr 6 2015, 9:15 PM

Python can edit CListValue's, but your patch doesn't mention this... which is concerning.
The ability for Python to manipulate internal state is not something to allow without some consideration.

source/gameengine/Ketsji/KX_Scene.cpp
2424	calling `fonts` is odd, this is really text objects, should call `texts` ?

Update to current trunk, rename "fonts" to "texts"

Python can edit CListValue's, but your patch doesn't mention this... which is concerning.

There is no case of a CListValue owned by python at the moment. (other than scene.cameras, but it disallowed now)

Porteries Tristan (panzergame) abandoned this revision.Dec 1 2015, 9:23 PM

Revision Contents
Changeset List

Path

Size

source/

gameengine/

Converter/

BL_BlenderDataConversion.cpp

4 lines

Ketsji/

KX_Camera.cpp

2 lines

KX_KetsjiEngine.cpp

72 lines

KX_MouseFocusSensor.cpp

14 lines

KX_Scene.h

66 lines

KX_Scene.cpp

148 lines

KX_SceneActuator.cpp

3 lines

Commit	Tree	Parents	Author	Summary	Date
c80cc4252eb6	a04afeab8170	1efd3439b694	Porteries Tristan	Remplacement de i par cam_idx dans les boucle de lecture de camera pour eviter… (Show More…)	Mar 2 2015, 7:50 PM
1efd3439b694	3cffec38629a	4052c004a3be	Porteries Tristan	BGE : Cleanup camera and font list (Show More…)	Feb 28 2015, 11:10 PM
4052c004a3be	7af465599dbb	90977fedf55d 3d305b5a37e8	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 27 2015, 5:38 PM
90977fedf55d	8b64df85511d	08a5f9150169 a12b2ec66dba	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 27 2015, 9:31 AM
08a5f9150169	ea91285f5b7c	123053beb63d c8f95cbb604c	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 27 2015, 12:18 AM
123053beb63d	5a250dd4b462	cbcb07edec8b 92f305a49080	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 25 2015, 10:23 PM
cbcb07edec8b	5f86f33e65db	3733cb76fca1 22dfb5062292	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 25 2015, 11:37 AM
3733cb76fca1	44acb07a4a29	06016f355404 87cff57207ca	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 25 2015, 7:34 AM
06016f355404	85480fff7d8e	4d559515ccf2 b13770215c97	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 23 2015, 6:16 PM
4d559515ccf2	c31d0a4b94fe	fed37b853f87 c451dba55078	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 23 2015, 11:08 AM
fed37b853f87	8a89306dba31	f76cb17474cb 03d945095af3	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 20 2015, 12:16 PM
f76cb17474cb	6a9d26c86110	d3a5e5a747e5 2fa593a6f7d0	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 16 2015, 11:29 AM
d3a5e5a747e5	58c6c7c3f9fd	93765567bc9c 225027ce5dea	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 15 2015, 9:50 PM
93765567bc9c	ef6881de9200	61336496804d dd3ade250ded	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 15 2015, 2:03 PM
61336496804d	4e79abff7624	0812c50d958c 3824e0f12437	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 14 2015, 5:57 PM
0812c50d958c	50ba11960534	860e6bcad47e 6e174205488b	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 14 2015, 12:18 AM
860e6bcad47e	c000dfcb9959	40affd183f1f fc3de690ac06	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 13 2015, 8:25 PM
40affd183f1f	ba6a593b84a8	0c11d57f7ef9 4aa51096a7f7	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init (Show More…)	Mar 11 2015, 4:53 PM
0c11d57f7ef9	818202581d01	5be60b6cbfb2 527302bc0b06	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 11 2015, 11:50 AM
5be60b6cbfb2	138f05a1a5de	90d6a742c4d1 56c0a3faef74	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 10 2015, 6:10 PM
90d6a742c4d1	f932f52d8277	13dd30b91bff 8a551394e50a	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 10 2015, 10:36 AM
13dd30b91bff	006e2f6ee581	5c79d6c84cbe 219937fc5dbd	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 9 2015, 5:41 PM
5c79d6c84cbe	27202ddd7292	59ec44c6ae7a a1549bc47a2e	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 9 2015, 11:33 AM
59ec44c6ae7a	bc34b27b5776	a5cd09232905 fee0e6e211ce	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 8 2015, 4:37 PM
a5cd09232905	7c625fbba653	33fc8c2d1f63 cf1227d4ad7a	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init (Show More…)	Mar 6 2015, 10:18 PM
33fc8c2d1f63	4e8c97ad0c1b	3f3a405c2130 90e1b83696b7	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 4 2015, 11:37 PM
3f3a405c2130	affac640e663	0187dd477594 d544bc5cd5ce	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 3 2015, 8:19 PM
0187dd477594	5cb8b98394b8	8511ad0cd1f4 ed5df501924f	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 3 2015, 6:01 PM
8511ad0cd1f4	644ffbfa0fb3	2a991d9334c7 b42a3d248531	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 3 2015, 12:52 PM
2a991d9334c7	d0e59139b58e	ede2cda50cb8 d2b6c6fd9b04	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 2 2015, 7:01 PM
ede2cda50cb8	ddb56765bb6c	bea5792eb01a 2058505da4e5	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 1 2015, 6:39 PM
bea5792eb01a	b1dc7eaf559f	f0bb3c7366bf f076eb482b3e	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Mar 1 2015, 4:46 PM
f0bb3c7366bf	11901b53fd5a	2a2f549b7634 9f6f151536b2	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 28 2015, 11:56 PM
2a2f549b7634	f86234e833ab	60a1e4769594 4ad31d5bab70	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 28 2015, 4:59 PM
60a1e4769594	11ce5bd8b009	7e2433d757db 15957a9e4d64	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 27 2015, 6:59 PM
7e2433d757db	8c7fad379850	eda2df5f8641 d7a877b69ca8	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 27 2015, 1:19 PM
eda2df5f8641	f5299602f29b	ca866bd15ffd 7293291a408a	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 27 2015, 7:22 AM
ca866bd15ffd	edcd5e5bb3a7	70040fd92dcc 0aa258117d52	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 26 2015, 7:07 PM
70040fd92dcc	2226fd67ca2d	9d668e471c89 6a65bc91e2d0	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 25 2015, 6:24 PM
9d668e471c89	9235f0a7f4f9	dc32acec20b2 07c61e93893c	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 24 2015, 12:56 PM
dc32acec20b2	78f0d05cf3cb	8b6b00db014f 2081fd1d7de4	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 23 2015, 7:08 PM
8b6b00db014f	4d68b59e5b78	f6a5488a72f1 67fcf5256d81	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 23 2015, 5:52 PM
f6a5488a72f1	32b88c7f4ea6	f1056aa6bf46 63b0a7feb289	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 22 2015, 3:59 PM
f1056aa6bf46	834b30b5b04e	496c13b93234 51b0ae8a85db	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 20 2015, 12:06 PM
496c13b93234	83c7e8246b20	d6d0dc463fc8 185e30122969	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 20 2015, 10:29 AM
d6d0dc463fc8	6aa7428ee932	1d2c88a04155 83220ab7fb9a	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 19 2015, 7:58 PM
1d2c88a04155	a9bbd6ee08dd	78e6056e7d51 0f652501c7b5	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 19 2015, 2:19 PM
78e6056e7d51	3462f8d398fd	f634022e190a 27d1446d24cc	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 19 2015, 12:50 PM
f634022e190a	0f0bef5911c9	9dd0b739d208 9fc2c3732878	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 19 2015, 11:04 AM
9dd0b739d208	e6f22c0618b8	4a982aef075c e6f40b4cebe5	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 17 2015, 7:17 PM
4a982aef075c	77dfb653f76e	d411f4914539 9a10b208bacd	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 16 2015, 10:48 AM
d411f4914539	8004bfaae31c	d56437bd6288 2e9105cc964a	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 15 2015, 3:28 PM
d56437bd6288	445333b7cf4a	6dacfcfb5659 35567d563dbc	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 15 2015, 1:28 PM
6dacfcfb5659	e9869e20a832	a248fb66e7c0 ab77466105ec	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 13 2015, 8:28 PM
a248fb66e7c0	8e552854b8b8	d7d61b0fb263 8de421bbf1c2	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 12 2015, 8:39 PM
d7d61b0fb263	a9b7f48ab845	2736de545db2 27b2ab8cf4ae	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 11 2015, 9:12 PM
2736de545db2	b61cd0d3f2c6	a1d3de78b234 de85d6cdbf13	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 11 2015, 6:06 PM
a1d3de78b234	65113f783173	82d0e2cb28d1 f2951c23cf8d	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 11 2015, 11:29 AM
82d0e2cb28d1	4a48cd6f3022	1efdf261bdc7 6971bd9a4fbb	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 10 2015, 9:45 AM
1efdf261bdc7	74fbd8c646cc	4516c17cebc6 12ed439d8ef9	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 9 2015, 9:56 AM
4516c17cebc6	ba3e899373fb	26431a22ecb1 a19229b80c18	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 8 2015, 10:34 PM
26431a22ecb1	4efe8b5ab846	88ff4417bcec 9c9dab095d49	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 7 2015, 10:05 PM
88ff4417bcec	4c73ce0dbb39	518eae2d6043 ca06c3343e4c	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 6 2015, 11:42 PM
518eae2d6043	165cfcc49c64	769780e13040 4e27f638286e	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 4 2015, 9:47 PM
769780e13040	f108a16243cb	ae0f18805698 15cd2222702d	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Feb 3 2015, 6:16 PM
ae0f18805698	1453923f0c1d	10b8deb9e2e3 26f9a9245387	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 31 2015, 10:59 PM
10b8deb9e2e3	bde069261e67	24489f8905e9 0da38ada0794	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 30 2015, 6:36 PM
24489f8905e9	ab18e65e9455	918a037b6f33 87986ed139a7	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 29 2015, 1:20 PM
918a037b6f33	8a6d78a55384	33961b3fa9fa cde9b1b948f0	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 28 2015, 4:02 PM
33961b3fa9fa	13ac1aede6b9	32149f061e21 3f8f4175c303	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 27 2015, 6:27 PM
32149f061e21	de5fd4a9cfea	4293bb92d061 58f7deca583a	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 27 2015, 1:22 PM
4293bb92d061	51480ef2e50e	3b6504febdc9 9e48f010c41d	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 27 2015, 12:56 PM
3b6504febdc9	0696aa80f2d9	52386c4d18a4 ce6ba965dc49	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 25 2015, 1:16 PM
52386c4d18a4	f009945ec336	7976008c4eb0 31219415d6c5	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 24 2015, 7:38 PM
7976008c4eb0	d59418691f5d	f67c13dd3ff4 d036ad552faf	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 24 2015, 10:54 AM
f67c13dd3ff4	7de33174e862	9577cc57c8b0 e40387b1e2af	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 23 2015, 1:01 PM
9577cc57c8b0	6d2b9a11489a	588e3d860280 7165db53f266	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 21 2015, 7:16 PM
588e3d860280	8ad82ac96c8c	59cf576039a5 4a4297ba02a8	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 19 2015, 10:02 PM
59cf576039a5	3e63c861d233	927d3d951b14 119ff676e1b3	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 17 2015, 7:46 PM
927d3d951b14	0a068210861d	acf22dd8ca71 3d503ea8d6fa	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 13 2015, 11:19 PM
acf22dd8ca71	bd05dd4f1636	d12d5c18c83f ab3f037ccc3f	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init (Show More…)	Jan 10 2015, 4:28 PM
d12d5c18c83f	fe703057e3e6	b8415372ca42 22ce525bcd4f	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 5 2015, 5:58 PM
b8415372ca42	b52506a4ae80	b5ec2d60e915 89b654dc56b3	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 5 2015, 1:30 PM
b5ec2d60e915	9a63149cc8d0	e03efc9d7d2c d8b00a3bf5c1	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 3 2015, 9:38 PM
e03efc9d7d2c	b6e82be9dedd	da6dab61dfbb f06335e12f0a	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 3 2015, 7:56 AM
da6dab61dfbb	721d3b572e88	5e9dbec7dee5 4bdd4aa63371	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Jan 1 2015, 12:13 PM
5e9dbec7dee5	a4a4213d63fe	dbc6b80fecb0 7f356c20dce0	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Dec 31 2014, 5:43 PM
dbc6b80fecb0	129241687320	e0b308bcdd7b 784517dfb965	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Dec 31 2014, 11:51 AM
e0b308bcdd7b	9c103a274a31	a04bb56e5018 936604e80104	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Dec 29 2014, 11:08 AM
a04bb56e5018	23988e04d3f1	3306bc3bdb3b cf178f71ac47	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init (Show More…)	Dec 26 2014, 3:11 PM
3306bc3bdb3b	80e137d697c8	df80921c5ba2 1fe7b84c7334	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Dec 21 2014, 1:40 PM
df80921c5ba2	0b2a1ce94716	71ab97ac591c 93c4ba7b70dd	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Dec 20 2014, 11:03 AM
71ab97ac591c	3efb6bbd87c9	5249fa42bfed 7a04c7f6d02a	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Dec 19 2014, 10:11 PM
5249fa42bfed	3832b0edebe8	7d3485249e7d 8627d65951b5	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Dec 18 2014, 12:21 PM
7d3485249e7d	994e4c0b2039	156ecc008819 17253bec0639	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Dec 14 2014, 2:59 PM
156ecc008819	a420de2817da	a98568c1a001 9c81833430d7	Porteries Tristan	Merge branch 'master' of git://git.blender.org/blender into init	Dec 13 2014, 8:09 PM
a98568c1a001	2b1a391bfacf	19eb700fefa3	Porteries Tristan	addons python	Dec 11 2014, 10:14 PM