Differential D11512
Render API: option for custom render engines to disable image file saving Authored by Thomas Lachmann (TL) on Jun 5 2021, 5:08 PM.
Details For some custom rendering engines it's advantageous not to write the image files to disk. To disable image/movie saving in RenderEngine addons use: This is only for rendering animations.
Diff Detail Event TimelineComment Actions
Comment Actions
Comment Actions I've disabled this code when "Use Image Save" is disabled, also writing a video is prevented. About the GUI: # RenderEngines also need to tell UI Panels that they are compatible with. # We recommend to enable all panels marked as BLENDER_RENDER, and then # exclude any panels that are replaced by custom panels registered by the # render engine, or that are not supported. In this case these 2 panels are not supported, right? Comment Actions About the GUI: I'm not sure if this needs to be hidden, because if a custom rendering engine disables file saving from blender, it should remove the output and stamp panel from the ui. I'm not sure about if remove this pannels is necessary. In most cases, each render engine can design a own 'Output' pannel, between others reasons, because some output formats aren't compatible with the own image output formats. Comment Actions My thinking is that removing the panels and optionally creating a own 'Output' panel is in the responsibility of the custom exporter. Comment Actions Add-ons can override the panels as they wish, but the default panel might as well take it into account. There's a design issue with this patch though. For the compositor and sequencer, you'd still need to output images. This new option can only really work when outputting images directly from the render engine. When combined with bl_use_postprocess = False this is not an issue, and maybe that's what you would use for network rendering anyway? But for regular renderers, it's not clear what the correct implementation is in Blender or the add-on. So either it needs to be limited to bl_use_postprocess = False, or some more design and implementation work is needed. Comment Actions My use case for this is a rendering engine which does it's own file saving, so I'm good with using bl_use_postprocess = False. Updated the patch accordingly. What is your point of view about the UI? Should Overwrite and Placeholder options disabled when this option is turned on? Comment Actions Since this is only applies when post-processing is disabled, I think it's ok to leave the output panel unaffected, since then you likely need to override the whole thing anyway. |