Line Art bug fix for error index in edge culling.
ClosedPublic
Actions

Authored by YimingWu (NicksBest) on Jun 5 2021, 5:15 PM.

Details

Reviewers

Commits

rB573011217479: LineArt: Fix edge clipping index error.
rBa496af8680f7: LineArt: Fix edge clipping index error.

Summary

So here's a small bug that's causing edge count to be incorrect in final culled list, just being offset exactly 1 entry. Now fixed.

This should be merged into master or 2.93 bug sprint as this is an actual bug.

Diff Detail

Repository: rB Blender

Event Timeline

YimingWu (NicksBest) requested review of this revision.Jun 5 2021, 5:15 PM

YimingWu (NicksBest) created this revision.

LGTM

We should probably as Jeroen how we should merge this into 2.93
I'm not sure what our workflow was merging fixes into the LTS releases.

This revision is now accepted and ready to land.Jun 5 2021, 8:26 PM

In D11513#294696, @Sebastian Parborg (zeddb) wrote:

LGTM

We should probably as Jeroen how we should merge this into 2.93
I'm not sure what our workflow was merging fixes into the LTS releases.

OK. I'll ask himbefore I do anything to 2.93.

Closed by commit rBa496af8680f7: LineArt: Fix edge clipping index error. (authored by YimingWu (NicksBest)). · Explain WhyJun 6 2021, 5:19 AM

This revision was automatically updated to reflect the committed changes.

YimingWu (NicksBest) added a commit: rBa496af8680f7: LineArt: Fix edge clipping index error..

Jeroen Bakker (jbakker) added a commit: rB573011217479: LineArt: Fix edge clipping index error..Jun 9 2021, 8:59 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

gpencil_modifiers/

intern/

lineart/

lineart_cpu.c

2 lines

Diff 37913

View Options

source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c

Line Art bug fix for error index in edge culling.ClosedPublicActions