Page MenuHome
Differential D11516

Rigify: Remove Legacy Mode
ClosedPublic
Actions

Authored by Demeter Dzadik (Mets) on Jun 5 2021, 7:36 PM.

Details

Reviewers
Alexander Gavrilov (angavrilov)
Commits
rBA7412d6c3e44b: Rigify: Remove Legacy Mode
Summary

This patch removes the Legacy Mode checkbox from the addon preferences and all associated code.

Ability to convert old legacy metarigs is not removed.
LegacyRig wrapper class is not removed.
Various legacy-only functions and imports were not removed, with the reasoning that they are still used by this unmaintained feature set.

Initially discussed in T88711, let's put any further discussion here, since that thread has many topics.

Diff Detail

Repository
rBA Blender Add-ons
Branch
arcpatch-D11516
Build Status
Buildable 15366
Build 15366: arc lint + arc unit

Event Timeline

Demeter Dzadik (Mets) requested review of this revision.Jun 5 2021, 7:36 PM
Demeter Dzadik (Mets) created this revision.
Demeter Dzadik (Mets) mentioned this in T88711: Rigify improvements in Blender 3 and beyond.Jun 6 2021, 4:04 AM
Alexander Gavrilov (angavrilov) requested changes to this revision.Jun 21 2021, 11:14 AM

Some preliminary comments based on purely reading the code without trying to run it.

rigify/__init__.py
110–111

Indentation not updated to match removal of `if', unless it's just displayed wrong in the browser.

557–558

Indentation?

rigify/rigs/experimental/super_chain.py
3 ↗(On Diff #37917)

As I mentioned in chat, utils.copy_bone != utils.bones.copy_bone, so this change is wrong. If you really want to import from utils.bones, use the _legacy_copy_bone as copy_bone syntax like utils/__init__.py.

rigify/rigs/faces/super_face.py
3 ↗(On Diff #37917)

Ditto.

rigify/ui.py
104

This seems wrong. It changes the code from detecting if any bone is non-updatable to only checking the first bone.

This revision now requires changes to proceed.Jun 21 2021, 11:14 AM
Demeter Dzadik (Mets) updated this revision to Diff 38612.Jun 22 2021, 8:07 PM
Demeter Dzadik (Mets) marked 3 inline comments as done.
  • Fix indentations and don't touch imports
Harbormaster completed remote builds in B15366: Diff 38612.Jun 22 2021, 8:07 PM
Demeter Dzadik (Mets) added inline comments.Jun 22 2021, 8:08 PM
rigify/__init__.py
110–111

Done, please see my question in D9094#292396 about auto-formatting for Rigify.

rigify/ui.py
104

This was accidental, not sure how it snuck in there, whoops! Thanks for catching.

Alexander Gavrilov (angavrilov) accepted this revision.Jun 23 2021, 3:40 PM

I think it's ok now.

This revision is now accepted and ready to land.Jun 23 2021, 3:40 PM
Closed by commit rBA7412d6c3e44b: Rigify: Remove Legacy Mode (authored by Demeter Dzadik (Mets)). · Explain WhyJun 23 2021, 4:44 PM
This revision was automatically updated to reflect the committed changes.
Demeter Dzadik (Mets) added a commit: rBA7412d6c3e44b: Rigify: Remove Legacy Mode.

Revision Contents
Changeset List

Diff 38612

View Options

rigify/__init__.py

Loading...
View Options

rigify/base_rig.py

Loading...
View Options

rigify/legacy/__init__.py

Loading...
View Options

rigify/legacy/generate.py

Loading...
View Options

rigify/legacy/metarig_menu.py

Loading...
View Options

rigify/legacy/metarigs/__init__.py

Loading...
View Options

rigify/legacy/metarigs/human.py

Loading...
View Options

rigify/legacy/metarigs/pitchipoy_human.py

Loading...
View Options

rigify/legacy/rig_lists.py

Loading...
View Options

rigify/legacy/rig_ui_pitchipoy_template.py

Loading...
View Options

rigify/legacy/rig_ui_template.py

Loading...
View Options

rigify/legacy/rigs/__init__.py

Loading...
View Options

rigify/legacy/rigs/basic/__init__.py

Loading...
View Options

rigify/legacy/rigs/basic/copy.py

Loading...
View Options

rigify/legacy/rigs/basic/copy_chain.py

Loading...
View Options

rigify/legacy/rigs/biped/__init__.py

Loading...
View Options

rigify/legacy/rigs/biped/arm/__init__.py

Loading...
View Options

rigify/legacy/rigs/biped/arm/deform.py

Loading...
View Options

rigify/legacy/rigs/biped/arm/fk.py

Loading...
View Options

rigify/legacy/rigs/biped/arm/ik.py

Loading...
View Options

rigify/legacy/rigs/biped/leg/__init__.py

Loading...
View Options

rigify/legacy/rigs/biped/leg/deform.py

Loading...
View Options

rigify/legacy/rigs/biped/leg/fk.py

Loading...
View Options

rigify/legacy/rigs/biped/leg/ik.py

Loading...
View Options

rigify/legacy/rigs/biped/limb_common.py

Loading...
View Options

rigify/legacy/rigs/finger.py

Loading...
View Options

rigify/legacy/rigs/misc/__init__.py

Loading...
View Options

rigify/legacy/rigs/misc/delta.py

Loading...
View Options

rigify/legacy/rigs/neck_short.py

Loading...
View Options

rigify/legacy/rigs/palm.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/__init__.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/limbs/__init__.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/limbs/arm.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/limbs/leg.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/limbs/limb_utils.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/limbs/paw.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/limbs/super_limb.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/limbs/ui.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/simple_tentacle.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/super_copy.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/super_face.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/super_finger.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/super_palm.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/super_torso_turbo.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/super_widgets.py

Loading...
View Options

rigify/legacy/rigs/pitchipoy/tentacle.py

Loading...
View Options

rigify/legacy/rigs/spine.py

Loading...
View Options

rigify/legacy/ui.py

Loading...
View Options

rigify/legacy/utils.py

Loading...
View Options

rigify/ui.py

Loading...