Details

Reviewers

Sybren A. Stüvel (sybren)
Luciano Muñoz Sessarego (looch)

Group Reviewers

Animation & Rigging

Maniphest Tasks

T88068: Alt-I in 3D Viewport doesn't respect active keying set

Commits

rB7fc220517f87: Fix T88068: Alt+I now respects keying set

Summary

This remaps Alt-I from delete_key_v3d_exec to delete_key_exec. On reproducing T88068, this fixes both the "location & rotation" keying set and the "power" keying set.

Diff Detail

Repository

rB Blender

Branch

arcpatch-D11528 (branched from master)

Build Status

Buildable 15127
Build 15127: arc lint + arc unit

Event Timeline

Xing Liu (xing) requested review of this revision.Jun 8 2021, 3:59 AM

Xing Liu (xing) created this revision.

Harbormaster completed remote builds in B15018: Diff 37975.Jun 8 2021, 3:59 AM

Xing Liu (xing) retitled this revision from Fix T88068: Changed default Alt-I behavior to be more intuitive --- This remaps Alt-I from delete_key_v3d_exec to delete_key_exec. On reproducing the report, this fixes the first bug (location and rotation keying set) but does not fix the power... to Fix T88068: Changed default Alt-I behavior to be more intuitive.Jun 8 2021, 4:00 AM

Xing Liu (xing) edited the summary of this revision. (Show Details)

Undo accidentally deleted line

Fix line misalignment

Xing Liu (xing) edited the summary of this revision. (Show Details)Jun 8 2021, 11:26 PM

Xing Liu (xing) added a reviewer: Sybren A. Stüvel (sybren).Jun 8 2021, 11:29 PM

Xing Liu (xing) set the repository for this revision to rB Blender.

Xing Liu (xing) added projects: Animation & Rigging, User Interface.

Sybren A. Stüvel (sybren) added reviewers: Luciano Muñoz Sessarego (looch), Animation & Rigging.Jun 10 2021, 12:12 PM

Sybren A. Stüvel (sybren) added a task: T88068: Alt-I in 3D Viewport doesn't respect active keying set.Jun 11 2021, 10:12 AM

This should probably also be addressed in the Industry Standard keymap then? That's stored in industry_compatible_data.py.

I'll apply that change when committing this patch. Thanks for the contribution!

Sybren A. Stüvel (sybren) accepted this revision.Jun 11 2021, 11:05 AM