Bokeh Blur node
AbandonedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Mar 1 2015, 2:12 AM.

Details

Reviewers

Alban O'Brien (aobn)

Group Reviewers

Documentation

Summary

As per T43469 'Document Missing Nodes' this diff adds Bokeh Image input and Bokeh Blur filter nodes.

Other changes:

-Added mention of Color Presets to Frame Nodes together with a description of how to add and delete them
-Added a description of the Shift Cut method of adding reroute nodes to Reroute Nodes
-Added mention of possibility of animating Switch node and added link to keyframe page in animation section (for this to work whole manual needs be compiled)
-Minor Punctuation changes

I have added the original developers of the Bokeh Blur node whom I had to contact for information. I'm not sure who to set as reviewer at this time as I understand Greg is on holiday.

Diff Detail

Event Timeline

Alban O'Brien (aobn) updated this revision to Diff 3657.Mar 1 2015, 2:12 AM

Alban O'Brien (aobn) retitled this revision from to Bokeh Blur node.

Alban O'Brien (aobn) updated this object.

Alban O'Brien (aobn) added a reviewer: Documentation.

Alban O'Brien (aobn) added a project: Documentation.

Alban O'Brien (aobn) added subscribers: Greg Zaal (gregzaal), Jeroen Bakker (jbakker), Monique Dewanchand (mdewanchand) and 2 others.

@Alban O'Brien (aobn), checking this report - and making minor edits

Noticed the text referring to a bug
Bug Note: This feature does not work in versions from 2.71 to 2.73a. - Is this bug known about / reported?

I searched the tracker but couldn't find anything related.
In general I rather not include references to bugs in documentation, if it fails the socket could be removed - or we fix the bug. But it seems like this bug is not even known about?

Committed rBM300, thanks for the patch! (made some edits, noted in the commit).

... forgot to mention, removed the section about OpenCL, each node shouldn't be documenting how to enable opencl,
better link to an existing page on compositor/OpenCL.

The only compositor OpenCL reference is in: manual/composite_nodes/editor.rst
but it doesn't explain anything at the moment.

Campbell Barton (campbellbarton) accepted this revision.Mar 3 2015, 3:17 AM

Campbell Barton (campbellbarton) added a reviewer: Campbell Barton (campbellbarton).

This revision is now accepted and ready to land.Mar 3 2015, 3:17 AM

Campbell Barton (campbellbarton) mentioned this in rBM300: D1152 Bokeh Blur node by @aobn.Mar 3 2015, 3:17 AM

committed, closing

This revision now requires review to proceed.Mar 3 2015, 3:21 AM

Campbell Barton (campbellbarton) abandoned this revision.Mar 3 2015, 3:23 AM

Thanks for the commit Campbell!

The bug was one I discovered after I received an explanation of what the input does from Jeroen and Monique. I submitted a bug report and Jeroen has resolved it. This is the task:

https://developer.blender.org/T43771

I wasn't sure what to do with the bug and probably should have asked on the doc list. I left it in because it is a bug in the current version and I wasn't sure how confusing this would be for people reading it now.

@Alban O'Brien (aobn), regarding documenting bugs - added note on this rBM313 for the writing style page.

If you check the number of bugfixes between 3month releases... its not really reasonable to do this IMHO.

eg:
http://wiki.blender.org/index.php/Dev:Ref/Release_Notes/2.71/Bug_Fixes