UI: Add the option to not display some socket labels
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jun 9 2021, 2:13 AM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Maniphest Tasks

T88542: Add the option to not display some socket labels

Commits

rBec98bb318b93: UI: Add the option to not display some socket labels

Summary

This commit adds a flag to disable displaying some socket labels which
just redundant eye sores. We still want to have a label, because that
information can potentially be accessed elsewhere in the UI.

The flag is used in a few geometry nodes.

Ref T88542

Diff Detail

Repository

rB Blender

Branch

node-socket-label-hide (branched from master)

Build Status

Buildable 15045
Build 15045: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jun 9 2021, 2:13 AM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B15045: Diff 38025.Jun 9 2021, 2:13 AM

Hans Goudey (HooglyBoogly) added a reviewer: Jacques Lucke (JacquesLucke).Jun 9 2021, 2:15 AM

Hans Goudey (HooglyBoogly) added projects: User Interface, Nodes & Physics.

Jacques Lucke (JacquesLucke) accepted this revision.Jun 9 2021, 1:52 PM

Jacques Lucke (JacquesLucke) added inline comments.

source/blender/makesdna/DNA_node_types.h
215	Not sure what you want to say with that last sentence. Is this any different than flags like `SOCK_MULTI_INPUT` or `SOCK_COMPACT`?

This revision is now accepted and ready to land.Jun 9 2021, 1:52 PM

HEYPictures (HEYPictures) awarded a token.Jun 9 2021, 3:49 PM

Hans Goudey (HooglyBoogly) marked an inline comment as done.Jun 9 2021, 3:56 PM

Hans Goudey (HooglyBoogly) added inline comments.

source/blender/makesdna/DNA_node_types.h
215	Yeah, I guess it's the same as some of the others, so it's not something that belongs here. But it is too bad we have these flags saved in the file.