Page MenuHome
Differential D11543

GPencil: Add surface normal entry to bGPDspoint.
ClosedPublic
Actions

Authored by YimingWu (NicksBest) on Jun 9 2021, 7:31 AM.

Details

Reviewers
Antonio Vazquez (antoniov)
Sebastian Parborg (zeddb)
Commits
rBf546b0800b91: GPencil: Add custom normal entry to bGPDspoint.
Summary

Does what it says. Also modified existing utility functions to take care of the new surface normal interpolation and so on.

Diff Detail

Repository
rB Blender

Event Timeline

YimingWu (NicksBest) requested review of this revision.Jun 9 2021, 7:31 AM
YimingWu (NicksBest) created this revision.
Antonio Vazquez (antoniov) edited reviewers, added: Sebastian Parborg (zeddb); removed: Grease Pencil.Jun 9 2021, 3:52 PM
Antonio Vazquez (antoniov) added a subscriber: Sebastian Parborg (zeddb).

In general the patch LGTM., just my concern about variable name. Waiting for @Sebastian Parborg (zeddb) opinion before approve the patch.

source/blender/makesdna/DNA_gpencil_types.h
104

Remove extra blank line

source/blender/makesrna/intern/rna_gpencil.c
1297

Not totally sure if we must name the variable surface_normal. If we are going to use only for this is ok, but if we want use it in the future for more things, maybe would be vec_normalor something like that.

@Sebastian Parborg (zeddb) waht do you think?

YimingWu (NicksBest) updated this revision to Diff 38072.Jun 9 2021, 4:34 PM

Rename surface_normal to custom_vector

YimingWu (NicksBest) updated this revision to Diff 38074.Jun 9 2021, 4:36 PM
YimingWu (NicksBest) marked 2 inline comments as done.

Fix empty new line in DNA.

Antonio Vazquez (antoniov) accepted this revision.Jun 9 2021, 4:41 PM
This revision is now accepted and ready to land.Jun 9 2021, 4:41 PM
Closed by commit rBf546b0800b91: GPencil: Add custom normal entry to bGPDspoint. (authored by YimingWu (NicksBest)). · Explain WhyJun 9 2021, 4:47 PM
This revision was automatically updated to reflect the committed changes.
YimingWu (NicksBest) added a commit: rBf546b0800b91: GPencil: Add custom normal entry to bGPDspoint..
YimingWu (NicksBest) added a reverting change: rBf42a501c6196: Revert "GPencil: Add custom normal entry to bGPDspoint.".Jun 9 2021, 6:11 PM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
25 lines
makesdna/
4 lines
makesrna/
intern/
8 lines

Diff 38038

View Options

source/blender/blenkernel/intern/gpencil_geom.c

Loading...
View Options

source/blender/makesdna/DNA_gpencil_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_gpencil.c

Loading...