Page MenuHome

Sequencer: Transform ImBuf Processor.
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Jun 9 2021, 3:55 PM.

Details

Summary

Inside the sequencer the cropping and transform of images/buffers were
implemented locally. This reduced the optimizations that a compiler
could do and added confusing code styles. This patch adds
IMB_transform to reduce the confusion and increases compiler
optimizations as more code can be inlined and we can keep track of
indices inside the inner loop.

Before:


After:

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Jun 9 2021, 3:55 PM
Jeroen Bakker (jbakker) created this revision.
This revision is now accepted and ready to land.Jun 9 2021, 4:09 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 9 2021, 4:14 PM

LGTM!

Sadly I couldn't reproduce the 20 -> 300 fps boost from the previous patch anymore.
Tried bisecting but found nothing. I instead reach 100 fps with that test file in a debug build now.

With this patch I go from 100 fps to 132fps in that file.

This revision was automatically updated to reflect the committed changes.