Proposed solution for Vertex Group select in Weight/VertexColor Paint modes. (T43389)
Needs RevisionPublic
Actions

Authored by Marco Oman (marom) on Mar 2 2015, 10:55 PM.

Details

Reviewers: None
Maniphest Tasks: T43389: Vertex Group select in Weight/VertexColor Paint modes.

Summary

Here is my second attempt at T43389.

What I have placed in the diffs is the following:

Added vertex selection mode (next to face selection) (view3d_header.c)
A few fixes to make vertex selection doable with RMB (drawobject.c, paint.c)
Enabled the Assign/Remove, Select/Deselect buttons on the vertex group panel (object_vgroup.c and properties_data_mesh.py)

In the original request the buttons Assign/remove were't mentioned but I think it make sense to have them too (and t's even easier to implement).

All this in Vertex Paint mode. I left out Texture Paint.

Diff Detail

Event Timeline

Marco Oman (marom) updated this revision to Diff 3668.Mar 2 2015, 10:55 PM

Marco Oman (marom) retitled this revision from to Proposed solution for Vertex Group select in Weight/VertexColor Paint modes. (T43389).

Marco Oman (marom) updated this object.

Marco Oman (marom) added a reviewer: Campbell Barton (campbellbarton).

Did you manage to test this patch? I can't imagine it would have been usable.

Vertex paint and texture paint don't currently have vertex selection,. this would need to be added first.

source/blender/editors/object/object_vgroup.c
2331	texture paint doesn't do vertex selection.
2332	code above checks for editmesh, this isnt needed.

This revision now requires changes to proceed.Mar 4 2015, 11:57 AM

Kévin Dietrich (kevindietrich) mentioned this in T43389: Vertex Group select in Weight/VertexColor Paint modes..Mar 15 2015, 4:48 AM

Kévin Dietrich (kevindietrich) added a task: T43389: Vertex Group select in Weight/VertexColor Paint modes..

Marco Oman (marom) updated this revision to Diff 3779.Mar 19 2015, 9:33 PM

Marco Oman (marom) updated this object.

Marco Oman (marom) edited edge metadata.

Marco Oman (marom) added a subscriber: chebboub houdifa (chebhou).

Hmmm, no news after a week. It is due to release rush or to the patch being rubbish?

Vertex selection on its own works.

However painting isn't reading from the selection.
so the vertex painting code needs to be updated too.

This revision now requires changes to proceed.Apr 22 2015, 4:14 PM

Campbell Barton (campbellbarton) removed a reviewer: Campbell Barton (campbellbarton).Aug 11 2016, 6:24 AM

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

properties_data_mesh.py

9 lines

source/

blender/

editors/

object/

object_vgroup.c

30 lines

Diff 3668

View Options

release/scripts/startup/bl_ui/properties_data_mesh.py