Details

Reviewers

Commits

rB35db01325f41: Compositor: Full frame Image node

Summary

Adds full frame implementation to Image node operations.
Mostly refactored into buffer utility methods for reuse in other
operations.
No functional changes.
1.8x faster than tiled fallback.

Diff Detail

Repository

rB Blender

Branch

cmp-node-image (branched from master)

Build Status

Buildable 15074
Build 15074: arc lint + arc unit

Event Timeline

Manuel Castilla (manzanilla) requested review of this revision.Jun 9 2021, 11:42 PM

Manuel Castilla (manzanilla) created this revision.

Harbormaster completed remote builds in B15074: Diff 38099.Jun 9 2021, 11:42 PM

Add missing consts
Merge branch 'master' into cmp-node-image

Harbormaster completed remote builds in B15147: Diff 38239.Jun 12 2021, 7:58 PM

Manuel Castilla (manzanilla) retitled this revision from [WIP]Compositor: Full frame image node to Compositor: Full frame image node.Jun 12 2021, 8:00 PM

Manuel Castilla (manzanilla) added a reviewer: Jeroen Bakker (jbakker).

Manuel Castilla (manzanilla) added a project: Compositing.

Manuel Castilla (manzanilla) added a parent revision: D11566: Fix: Image node alpha socket converted to operations twice.

Manuel Castilla (manzanilla) edited the summary of this revision. (Show Details)Jun 13 2021, 10:47 AM

Manuel Castilla (manzanilla) retitled this revision from Compositor: Full frame image node to Compositor: Full frame Image node.Jun 13 2021, 11:14 AM

Manuel Castilla (manzanilla) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) requested changes to this revision.Jun 15 2021, 2:43 PM

Jeroen Bakker (jbakker) added inline comments.

source/blender/compositor/intern/COM_MemoryBuffer.h
112	owns_data_ is shorter.
source/blender/compositor/intern/COM_buffer_util.h
43	Would rather see these as methods on the MemoryBuffer. There are more discoverable there and names can be shortened. `dst.copy_from(src, area)` `dst.fill(area, value)`

This revision now requires changes to proceed.Jun 15 2021, 2:43 PM

Move utility methods to MemoryBuffer
Rename rect to area
Rename is_buffer_data_owned_ to owns_data_

Harbormaster completed remote builds in B15225: Diff 38362.Jun 16 2021, 12:09 AM

Merge branch 'master' into cmp-node-image

Harbormaster completed remote builds in B15256: Diff 38413.Jun 16 2021, 4:54 PM

Manuel Castilla (manzanilla) mentioned this in T88150: Full Frame Compositor.Jun 17 2021, 10:43 PM

Jeroen Bakker (jbakker) accepted this revision.Jun 21 2021, 10:25 AM

This revision is now accepted and ready to land.Jun 21 2021, 10:25 AM

Closed by commit rB35db01325f41: Compositor: Full frame Image node (authored by Manuel Castilla (manzanilla)). · Explain WhyJun 23 2021, 5:56 PM

This revision was automatically updated to reflect the committed changes.

Manuel Castilla (manzanilla) added a commit: rB35db01325f41: Compositor: Full frame Image node.

Manuel Castilla (manzanilla) edited the summary of this revision. (Show Details)Jun 23 2021, 9:39 PM

Compositor: Full frame Image node
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 38099

source/blender/compositor/CMakeLists.txt

source/blender/compositor/COM_defines.h

source/blender/compositor/intern/COM_MemoryBuffer.h

source/blender/compositor/intern/COM_MemoryBuffer.cc

source/blender/compositor/intern/COM_MultiThreadedOperation.h

source/blender/compositor/intern/COM_buffer_util.h

source/blender/compositor/intern/COM_buffer_util.cc

source/blender/compositor/operations/COM_ImageOperation.h

source/blender/compositor/operations/COM_ImageOperation.cc

source/blender/compositor/operations/COM_MultilayerImageOperation.h

source/blender/compositor/operations/COM_MultilayerImageOperation.cc

Compositor: Full frame Image nodeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38099

source/blender/compositor/CMakeLists.txt

source/blender/compositor/COM_defines.h

source/blender/compositor/intern/COM_MemoryBuffer.h

source/blender/compositor/intern/COM_MemoryBuffer.cc

source/blender/compositor/intern/COM_MultiThreadedOperation.h

source/blender/compositor/intern/COM_buffer_util.h

source/blender/compositor/intern/COM_buffer_util.cc

source/blender/compositor/operations/COM_ImageOperation.h

source/blender/compositor/operations/COM_ImageOperation.cc

source/blender/compositor/operations/COM_MultilayerImageOperation.h

source/blender/compositor/operations/COM_MultilayerImageOperation.cc

Compositor: Full frame Image node
ClosedPublic
Actions

Revision Contents
Changeset List