Details

Reviewers

Commits

rB35db01325f41: Compositor: Full frame Image node

Summary

Adds full frame implementation to Image node operations.
Mostly refactored into buffer utility methods for reuse in other
operations.
No functional changes.
1.8x faster than tiled fallback.

Diff Detail

Repository

rB Blender

Branch

cmp-node-image (branched from master)

Build Status

Buildable 15256
Build 15256: arc lint + arc unit

Event Timeline

Manuel Castilla (manzanilla) requested review of this revision.Jun 9 2021, 11:42 PM

Manuel Castilla (manzanilla) created this revision.

Harbormaster completed remote builds in B15074: Diff 38099.Jun 9 2021, 11:42 PM

Add missing consts
Merge branch 'master' into cmp-node-image

Harbormaster completed remote builds in B15147: Diff 38239.Jun 12 2021, 7:58 PM

Manuel Castilla (manzanilla) retitled this revision from [WIP]Compositor: Full frame image node to Compositor: Full frame image node.Jun 12 2021, 8:00 PM

Manuel Castilla (manzanilla) added a reviewer: Jeroen Bakker (jbakker).

Manuel Castilla (manzanilla) added a project: Compositing.

Manuel Castilla (manzanilla) added a parent revision: D11566: Fix: Image node alpha socket converted to operations twice.

Manuel Castilla (manzanilla) edited the summary of this revision. (Show Details)Jun 13 2021, 10:47 AM

Manuel Castilla (manzanilla) retitled this revision from Compositor: Full frame image node to Compositor: Full frame Image node.Jun 13 2021, 11:14 AM

Manuel Castilla (manzanilla) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) requested changes to this revision.Jun 15 2021, 2:43 PM

Jeroen Bakker (jbakker) added inline comments.

source/blender/compositor/intern/COM_MemoryBuffer.h
112	owns_data_ is shorter.
source/blender/compositor/intern/COM_buffer_util.h
42 ↗	(On Diff #38239)	Would rather see these as methods on the MemoryBuffer. There are more discoverable there and names can be shortened. `dst.copy_from(src, area)` `dst.fill(area, value)`