Page MenuHome

Fix: VSE indexer seeking not working correctly
ClosedPublic

Authored by Sebastian Parborg (zeddb) on Jun 10 2021, 2:43 AM.

Details

Summary

Because of the added sanity checks in rB14508ef100c9 (D11492), seeking in proxies would not work correctly any more.
This is because it wasn't working as intended before, but in most cases this wouldn't be noticeable.
However now when the sanity checks are tripped it is very noticeable that something is wrong

The indexer tried to use dts values for time stamps when we used pts in our decode functions to get the time positions.
This would make it start in the wrong GOP frames when searching. Now that we enforce no crossing of GOP frames when decoding after seek, this would lead to issues.

Now we correctly use pts (or dts if pts is not available) and thus we don't have any seeking issues because of time stamp format missmatch.

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) requested review of this revision.Jun 10 2021, 2:43 AM
Sebastian Parborg (zeddb) created this revision.
Sebastian Parborg (zeddb) edited the summary of this revision. (Show Details)
Sebastian Parborg (zeddb) edited the summary of this revision. (Show Details)

Missed using dts while stepping forward inside the same GOP.

I would be perhaps more verbose in commit message and mainly mention that this is because 14508ef100c9 broke some stuff.
Now I understand changes, but when I will have to return to this patch after year, I will be pretty lost probably.

This revision is now accepted and ready to land.Jun 11 2021, 1:04 PM