Fix: VSE search in mpegts files would fail
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Jun 10 2021, 2:47 AM.

Details

Reviewers

Richard Antalik (ISS)

Commits

rB444a8cbc2fd9: Fix: VSE search in mpegts files would fail
rBc0367b19e20e: Fix: VSE search in mpegts files would fail

Summary

ffmpeg_generic_seek_workaround didn't work properly and our start pts calculation was wrong.

This depends on D11561 (for the timestamp_from_pts_or_dts function and other misc changes).

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) requested review of this revision.Jun 10 2021, 2:47 AM

Sebastian Parborg (zeddb) created this revision.

Sebastian Parborg (zeddb) edited the summary of this revision. (Show Details)Jun 10 2021, 2:55 AM

Sebastian Parborg (zeddb) updated this revision to Diff 38170.Jun 10 2021, 10:16 PM

I found issue here as well,

00013.MTS16 MBDownload

Seek to frame 69 and frame by frame backwards, there will be frames missing.

Fixed seeking when two packets had the same pts in a row (without it being a keyframe)

Richard Antalik (ISS) accepted this revision.Jun 11 2021, 1:47 PM

This revision is now accepted and ready to land.Jun 11 2021, 1:47 PM

Closed by commit rBc0367b19e20e: Fix: VSE search in mpegts files would fail (authored by Sebastian Parborg (zeddb)). · Explain WhyJun 11 2021, 2:05 PM

This revision was automatically updated to reflect the committed changes.

Sebastian Parborg (zeddb) added a commit: rBc0367b19e20e: Fix: VSE search in mpegts files would fail.

Jeroen Bakker (jbakker) added a commit: rB444a8cbc2fd9: Fix: VSE search in mpegts files would fail.Jun 30 2021, 9:48 AM

Revision Contents
Changeset List

Path

Size

intern/

ffmpeg/

ffmpeg_compat.h

20 lines

source/

blender/

imbuf/

intern/

anim_movie.c

81 lines

Diff 38196

View Options

intern/ffmpeg/ffmpeg_compat.h