Fix: VSE timecodes being used even when turned off.
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Jun 10 2021, 2:42 PM.

Details

Reviewers

Commits

rBa68f5456e48b: Fix: VSE timecodes being used even when turned off.
rB1fb2eaf1c5ed: Fix: VSE timecodes being used even when turned off.

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) requested review of this revision.Jun 10 2021, 2:42 PM

Sebastian Parborg (zeddb) created this revision.

Is is possible to sanitize get_proxy_filename and get_tc_filename so it won't crash too?

To me the asserts should be enough?

Those functions should never be called with the _NONE enums.
If they are, something is wrong and should be fixed.

I didn't manage to trigger any asserts during my testing, so it seems to be working as intended now.

In D11567#296518, @Sebastian Parborg (zeddb) wrote:

To me the asserts should be enough?

Those functions should never be called with the _NONE enums.
If they are, something is wrong and should be fixed.

I didn't manage to trigger any asserts during my testing, so it seems to be working as intended now.

Right this is probably good enough. I tend to be as safe as possible usually so I suggested this.

This revision is now accepted and ready to land.Jun 11 2021, 12:52 PM

Closed by commit rB1fb2eaf1c5ed: Fix: VSE timecodes being used even when turned off. (authored by Sebastian Parborg (zeddb)). · Explain WhyJun 11 2021, 2:05 PM

This revision was automatically updated to reflect the committed changes.

Sebastian Parborg (zeddb) added a commit: rB1fb2eaf1c5ed: Fix: VSE timecodes being used even when turned off..

Jeroen Bakker (jbakker) added a commit: rBa68f5456e48b: Fix: VSE timecodes being used even when turned off..Jun 30 2021, 9:48 AM