Phabricator: Extend CONDUIT API to support xaction transactions
ClosedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Jun 10 2021, 2:46 PM.

Details

Reviewers

Commits

rP883046f69f2e: Phabricator: Extend CONDUIT API to support xaction transactions
rPeced78a5917c: Phabricator: Extend CONDUIT API to support xaction transactions

Summary

Example of null transactions and their expected value:

D9:transaction 44 - "abandon"
D22:transaction 112 - "commit"
D22:transaction 96 - "accept"
D1123:transaction 22872 - "rethink"

This is the cheapest way I found so far to get more information from those transactions. Tested and working in my local phabricator.

Diff Detail

Repository: rP Phabricator

Event Timeline

Dalai Felinto (dfelinto) requested review of this revision.Jun 10 2021, 2:46 PM

Dalai Felinto (dfelinto) created this revision.

Requesting changes to indicate that the patch is not ready for commit, and some discussion/clarification and, possibly, changes needed.

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php
300	Why is this not a $type = DifferentialTransaction::TYPE_ACTION; $fields = array( 'old' => $xaction->getOldValue(), 'new' => $xaction->getNewValue(), ); ?

This revision now requires changes to proceed.Jun 10 2021, 2:55 PM

Dalai Felinto (dfelinto) updated this revision to Diff 38153.Jun 10 2021, 4:33 PM

Sergey Sharybin (sergey) accepted this revision.Jun 10 2021, 4:33 PM

This revision is now accepted and ready to land.Jun 10 2021, 4:33 PM

As it turned out, the old value is always null in those cases.

Maybe they needs to be set somewhere else.
Still feels more consistent to have a transaction type a new value.

And for the records, this is the amount of action transactions we have for differentials:

abandon 911
accept 1432
claim 621
commit 1361
reclaim 18
reject 1038
reopen 35
request_review 6
resign 29
rethink 86

For the records, the patch is already committed. I will change the status to get something from the phabricator data. Ignore any subsequent updates here.

Fake planned changes

Dalai Felinto (dfelinto) updated this revision to Diff 38195.Jun 11 2021, 12:47 PM

This revision is now accepted and ready to land.Jun 11 2021, 12:47 PM

Dalai Felinto (dfelinto) closed this revision.Jun 11 2021, 7:54 PM

Dalai Felinto (dfelinto) added commits: rPeced78a5917c: Phabricator: Extend CONDUIT API to support xaction transactions, rP883046f69f2e: Phabricator: Extend CONDUIT API to support xaction transactions.