Fix: Segmentation fault when reordering animation channels
ClosedPublic
Actions

Authored by Maxime Casas (troopy28) on Jun 10 2021, 2:57 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)

Commits

rBb4adb85933f9: Fix T89033: segfault reordering animation channels

Summary

This patch provides a fix to T89033.

Under some specific conditions, the list "act->curves" is empty in the "join_groups_action_temp" function. In particular, this happens when a scene contains an action that has not been pushed down, and with no keyframe in it.

This patch solves this issue by simply ensuring that this list is empty before doing the operations with it.

Diff Detail

Repository

rB Blender

Branch

arcpatch-D11569 (branched from master)

Build Status

Buildable 15137
Build 15137: arc lint + arc unit

Event Timeline

Maxime Casas (troopy28) requested review of this revision.Jun 10 2021, 2:57 PM

Maxime Casas (troopy28) created this revision.

Formatting

Harbormaster completed remote builds in B15137: Diff 38213.Jun 11 2021, 4:25 PM

Sybren A. Stüvel (sybren) added inline comments.Jun 11 2021, 4:25 PM

source/blender/editors/animation/anim_channels_edit.c
1352–1353	This doesn't adhere to the code style, be sure to configure your IDE to use Clang-Format or run `make format` before submitting your patch. I'll address this when landing the patch.