Differential D11580

Sequencer: Do not redraw during playback.
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jun 11 2021, 2:48 PM.

Tags

Subscribers

Peter Fog (tintwotin)

Details

Reviewers

Richard Antalik (ISS)

Commits

rB7b76a160a464: Sequencer: Do not redraw during playback.

Summary

When using large sequences including audio the drawing of the audio on
top of the strip takes a lot of time. This effects the playback
performance heavily.

During the animation playback performance there was a solution for this
by only drawing the playhead overlay. This was reverted for the sequence
editor as it didn't update the color strips when they were animated.

This patch checks if there are animated color strips if so the full
screen is redrawn, otherwise only the playhead is redrawn.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Jun 11 2021, 2:48 PM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B15130: Diff 38202.Jun 11 2021, 2:48 PM

Jeroen Bakker (jbakker) added a reviewer: Richard Antalik (ISS).Jun 11 2021, 2:48 PM

Jeroen Bakker (jbakker) added projects: Performance, Video Sequencer.

Jeroen Bakker (jbakker) added inline comments.Jun 11 2021, 2:52 PM

source/blender/editors/space_sequencer/sequencer_draw.c
2458–2459	remove these lines

Remove commented out code.

Harbormaster completed remote builds in B15132: Diff 38204.Jun 11 2021, 2:52 PM

Maybe the color strips could be drawn as gradients instead? Imo, having them animated, draws too much attention while playing.

Richard Antalik (ISS) added inline comments.Jun 11 2021, 3:28 PM

source/blender/editors/space_sequencer/sequencer_draw.c
2458–2459	This is normally hidden for users, but I sometimes need view cache state for debugging. Why did you disable it?

Oops, I have commented too late. I see now why cache draw isn't applicable here, will have to implement this in other way, so accepting

This revision is now accepted and ready to land.Jun 11 2021, 3:39 PM

Closed by commit rB7b76a160a464: Sequencer: Do not redraw during playback. (authored by Jeroen Bakker (jbakker)). · Explain WhyJun 11 2021, 3:52 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB7b76a160a464: Sequencer: Do not redraw during playback..

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

include/

1 line

screen/

13 lines

space_sequencer/

sequencer_draw.c

62 lines

sequencer_edit.c

37 lines

Diff 38209

source/blender/editors/include/ED_sequencer.h

Loading...

source/blender/editors/screen/screen_ops.c

Loading...

source/blender/editors/space_sequencer/sequencer_draw.c

Loading...

source/blender/editors/space_sequencer/sequencer_edit.c

Loading...