Page MenuHome
Differential D11590

Remove redundant increment node tree current socket index
AcceptedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Jun 13 2021, 7:33 AM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Summary

ntree->cur_index was being incremented twice in make_socket_interface.

As the value is only used once, I can't see any reason for incrementing this twice.

Diff Detail

Repository
rB Blender
Branch
TEMP-TOUBLE-INCREMENT (branched from master)
Build Status
Buildable 15149
Build 15149: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Jun 13 2021, 7:33 AM
Campbell Barton (campbellbarton) created this revision.
Harbormaster completed remote builds in B15149: Diff 38243.Jun 13 2021, 7:33 AM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Jun 13 2021, 7:47 AM
Campbell Barton (campbellbarton) added a reviewer: Jacques Lucke (JacquesLucke).
Campbell Barton (campbellbarton) retitled this revision from Remove extra increment to the node sockets unique number to Remove redundant increment node tree current socket index.
Jacques Lucke (JacquesLucke) accepted this revision.Jun 14 2021, 10:18 AM
This revision is now accepted and ready to land.Jun 14 2021, 10:18 AM
Campbell Barton (campbellbarton) mentioned this in rB2db09f67a4f1: Nodes: remove redundant increment node tree current socket index.Jun 14 2021, 10:48 AM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
4 lines

Diff 38243

View Options

source/blender/blenkernel/intern/node.cc

Loading...