Paths

Table of Contentst

Differential D11612

DrawManager: Cache material offsets.
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jun 15 2021, 1:33 PM.

Tags

Subscribers

None

Details

Reviewers

Germano Cavalcante (mano-wii)

Commits

rB174ed69c1ba8: DrawManager: Cache material offsets.

Summary

When using multiple materials in a single mesh the most time is spend in
counting the offsets of each material for the sorting.

This patch moves the counting of the offsets to render mesh data and
caches it as long as the geometry doesn't change.

This patch doesn't include multithreading of this code.

Diff Detail

Repository

Branch

master

Build Status

Buildable 15209
Build 15209: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Jun 15 2021, 1:33 PM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B15202: Diff 38332.Jun 15 2021, 1:33 PM

Jeroen Bakker (jbakker) added a reviewer: Germano Cavalcante (mano-wii).Jun 15 2021, 1:34 PM

Jeroen Bakker (jbakker) added projects: Performance, EEVEE & Viewport.

Renamed SEQ_sequence_lookup_destruct to SEQ_sequence_lookup_free.
Removed unused parameter in seq_sequence_lookup_new.
Use BLI_ghash_str_new to create lookup hashmap, all names are zero-terminated.

Harbormaster completed remote builds in B15206: Diff 38336.Jun 15 2021, 3:14 PM

Revert "DrawManager: Cache material offsets."

Harbormaster completed remote builds in B15207: Diff 38337.Jun 15 2021, 3:15 PM

Resend diff after incorrect sending the previous time.

Harbormaster completed remote builds in B15209: Diff 38339.Jun 15 2021, 3:18 PM

Looks good.
Maybe the name mat_offsets.tri could be more descriptive like mat_offsets.tri_len, but it's not really a problem.

This revision is now accepted and ready to land.Jun 15 2021, 3:22 PM

Well they aren't really lengths or counts. in the end they are offsets. I found mat_offsets.tri_offsets a bit too long.

Closed by commit rB174ed69c1ba8: DrawManager: Cache material offsets. (authored by Jeroen Bakker (jbakker)). · Explain WhyJun 15 2021, 3:31 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB174ed69c1ba8: DrawManager: Cache material offsets..

Jeroen Bakker (jbakker) mentioned this in T88550: Mesh Optimization Project Progress.Jun 15 2021, 4:40 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

intern/

draw_cache_extract.h

9 lines

draw_cache_extract_mesh.cc

14 lines

draw_cache_extract_mesh_private.h

7 lines

draw_cache_extract_mesh_render_data.c

104 lines

draw_cache_impl_mesh.c

2 lines

mesh_extractors/

extract_mesh_ibo_tris.cc

47 lines

Diff 38339

source/blender/draw/intern/draw_cache_extract.h

Loading...

source/blender/draw/intern/draw_cache_extract_mesh.cc

Loading...

source/blender/draw/intern/draw_cache_extract_mesh_private.h

Loading...

source/blender/draw/intern/draw_cache_extract_mesh_render_data.c

Loading...

source/blender/draw/intern/draw_cache_impl_mesh.c

Loading...

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_tris.cc

Loading...