VSE: Refactor transform operator code
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Jun 16 2021, 8:52 AM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rB78693d524c13: VSE: Refactor transform operator code

Summary

Patch must be applied on top of D11493.

Refactor freeSeqData so it is readable.

One strip can have multiple transform operations defined. To prevent
processing strip multiple times, build SeqCollection and use
sequencer iterator instead of iterating TransData directly.

No functional changes.

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Jun 16 2021, 8:52 AM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B15239: Diff 38382.Jun 16 2021, 8:52 AM

Build SeqCollection instead of iterating TransData
Cleanup: unused arguments
Split seq_transform_update_effects from freeSeqData

Harbormaster completed remote builds in B15242: Diff 38385.Jun 16 2021, 9:29 AM

Richard Antalik (ISS) edited the summary of this revision. (Show Details)Jun 16 2021, 9:33 AM

From my side seems all fine.

As mentioned in some previous review, Germano is in the transform code. Not sure you talked to him, and not sure he wants to be a reviewer for the sequencer-related changes in the transform module.

Check with him, and move from there. To me the code seem fine.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 17 2021, 4:05 AM

Closed by commit rB78693d524c13: VSE: Refactor transform operator code (authored by Richard Antalik (ISS)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB78693d524c13: VSE: Refactor transform operator code.