Page MenuHome

Voxel Remesher: Make smooth shading output automatic
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Jun 16 2021, 9:23 PM.

Details

Summary

Previously the smooth shading of the voxel remesher was controlled by a
mesh property. With this change, the output will try to match the
current shading of the object. This only takes into consideration the
shading mode of the first polygon of the model, but it is probably what
most users expect as it works as intended with the shade smooth/flat
object mode options.

Diff Detail

Repository
rB Blender
Branch
sculpt-remesh-normals-automatic (branched from master)
Build Status
Buildable 15261
Build 15261: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Jun 16 2021, 9:23 PM
Pablo Dobarro (pablodp606) created this revision.
Pablo Dobarro (pablodp606) added inline comments.
source/blender/makesdna/DNA_mesh_types.h
284

These are unrelated clang format changes. Probably clang format needs to be applied in master globally to clean this up.

There is another place where use_remesh_smooth_normals is used as well, that has to be removed.

This revision is now accepted and ready to land.Jun 18 2021, 11:16 AM
Julien Kaspar (JulienKaspar) accepted this revision.EditedJun 18 2021, 2:18 PM

Seems to work exactly like expected. @Pablo Dobarro (pablodp606) But you should also ideally implement the same change for the dyntopo settings.
In there is also still a toggle for smooth shading that should be handled the same way as the remesher.