Page MenuHome
Differential D11627

Compositor: Full frame Box Mask node
ClosedPublic
Actions

Authored by Manuel Castilla (manzanilla) on Jun 16 2021, 11:41 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Commits
rBa4a72bffd33a: Compositor: Full frame Box Mask node
Summary

Adds full frame implementation to Box Mask node operation.
No functional changes.

Diff Detail

Repository
rB Blender
Branch
cmp-node-box-mask (branched from master)
Build Status
Buildable 15263
Build 15263: arc lint + arc unit

Event Timeline

Manuel Castilla (manzanilla) requested review of this revision.Jun 16 2021, 11:41 PM
Manuel Castilla (manzanilla) created this revision.
Harbormaster completed remote builds in B15263: Diff 38429.Jun 16 2021, 11:41 PM
Manuel Castilla (manzanilla) added a reviewer: Jeroen Bakker (jbakker).Jun 16 2021, 11:42 PM
Manuel Castilla (manzanilla) added a project: Compositing.
Manuel Castilla (manzanilla) mentioned this in T88150: Full Frame Compositor.Jun 17 2021, 10:43 PM
Jeroen Bakker (jbakker) requested changes to this revision.Jun 21 2021, 11:08 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/compositor/operations/COM_BoxMaskOperation.cc
133

Same as for Ellipse node. Move switch statement outside the inner loop.

This revision now requires changes to proceed.Jun 21 2021, 11:08 AM
Manuel Castilla (manzanilla) updated this revision to Diff 39760.Jul 20 2021, 11:31 PM
  • Merge branch 'master' into cmp-node-box-mask
  • Move switch statement outside the inner loop
Harbormaster completed remote builds in B15929: Diff 39760.Jul 20 2021, 11:31 PM
Manuel Castilla (manzanilla) marked an inline comment as done.Jul 20 2021, 11:31 PM
Jeroen Bakker (jbakker) accepted this revision.Jul 26 2021, 11:27 AM
This revision is now accepted and ready to land.Jul 26 2021, 11:27 AM
Closed by commit rBa4a72bffd33a: Compositor: Full frame Box Mask node (authored by Manuel Castilla (manzanilla)). · Explain WhyJul 26 2021, 9:52 PM
This revision was automatically updated to reflect the committed changes.
Manuel Castilla (manzanilla) added a commit: rBa4a72bffd33a: Compositor: Full frame Box Mask node.

Revision Contents
Changeset List

PathSize
source/
blender/
compositor/
operations/
10 lines
73 lines

Diff 38429

View Options

source/blender/compositor/operations/COM_BoxMaskOperation.h

Loading...
View Options

source/blender/compositor/operations/COM_BoxMaskOperation.cc

Loading...