Performance: Flush selection to edges/faces.
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jun 18 2021, 9:33 AM.

Details

Reviewers

Germano Cavalcante (mano-wii)
Campbell Barton (campbellbarton)

Commits

rBb9ccfb89ce91: Performance: Flush selection to edges/faces.

Summary

This patch uses threading to flush selection from verts to edges and
from edges to faces. The solution is lockless and should scale well on
modern CPU architectures.

Master:

Patch:

End user performance went from 3.9 to 4.6 FPS (Stanford Dragon) but that
was measured on a Intel Core i7-6700 CPU and AMD RX480 Gpu. The more
cores the better improvements you get.

Diff Detail

Repository

rB Blender

Branch

arcpatch-D11644 (branched from master)

Build Status

Buildable 15325
Build 15325: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Jun 18 2021, 9:33 AM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B15302: Diff 38491.Jun 18 2021, 9:33 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 18 2021, 9:35 AM

Jeroen Bakker (jbakker) added reviewers: Germano Cavalcante (mano-wii), Campbell Barton (campbellbarton).

Jeroen Bakker (jbakker) added projects: Performance, Modeling.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 18 2021, 9:39 AM

Jeroen Bakker (jbakker) mentioned this in T88550: Mesh Optimization Project Progress.

Bataev Artem (shader) awarded a token.Jun 18 2021, 9:34 PM

Fran Marz (franMarz) awarded a token.Jun 19 2021, 1:34 AM

Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Jun 19 2021, 8:49 AM

Resynced with master. Update counting on the fly.

Harbormaster completed remote builds in B15325: Diff 38549.Jun 21 2021, 9:05 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 21 2021, 9:06 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 21 2021, 9:13 AM

Overall looks good. Just a few opinions on the style:

source/blender/bmesh/intern/bmesh_marking.c
337	I don't know if it's already been decided but, it was argued that the conversion for callbacks is to have the `_fn` suffix. Different suffixes are currently being used (`_cb`, `_func`...) it would be nice to have a convention on this.
388	Maybe `bm_mesh_select_mode_flush_reduce_fn` to have a suffix indicating that it will be used as a callback only.
397	Seeing other uses of `BM_iter_parallel`, instead of a value for `min_iter_per_thread`, we could use: `settings.use_threading = elem_len >= BM_OMP_LIMIT;` (just an idea)