Paths

Table of Contentst

Differential D11672

Fix T89367: Reject negative indices in EDBM_elem_from_index_any
AbandonedPublic
Actions

Authored by Fen (chemicalcrux) on Jun 22 2021, 6:17 PM.

Tags

None

Subscribers

Campbell Barton (campbellbarton)

Details

Reviewers: None
Maniphest Tasks: T89367: Running select_linked_pick with a negative index crashes Blender with an access violation

Summary

This revision fixes T89367. It returns NULL from EDBM_elem_from_index_any when the index is less than zero.

Since this should normally never happen, I wrapped the check in an UNLIKELY macro.

Diff Detail

Event Timeline

Fen (chemicalcrux) requested review of this revision.Jun 22 2021, 6:17 PM

Fen (chemicalcrux) created this revision.

Fen (chemicalcrux) mentioned this in T89367: Running select_linked_pick with a negative index crashes Blender with an access violation.

Added some context.

Thanks but committed alternate fix rB635b4db162731a100c255faa11ca9e2bd40d7d93

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

mesh/

editmesh_utils.c

4 lines

Diff 38609

source/blender/editors/mesh/editmesh_utils.c

Loading...