Page MenuHome
Differential D11682

Division by zero when there are no lights and only emissive surfaces
ClosedPublic
Actions

Authored by William Leeson (leesonw) on Jun 23 2021, 7:52 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T79190: Cycles PMJ adaptive sampling working poorly with many bounces
Commits
rCfaf8f5f353fc: Division by zero when there are no lights and only emissive surfaces
rB5eed7cdc8c17: Division by zero when there are no lights and only emissive surfaces
Summary

When rendering the test scene in T79190 which has only emissive surfaces a division by zero occurs. This is a simple patch to remove this.

Diff Detail

Repository
rB Blender

Event Timeline

William Leeson (leesonw) requested review of this revision.Jun 23 2021, 7:52 AM
William Leeson (leesonw) created this revision.
Pratik Borhade (PratikPB2123) mentioned this in T89379: Fixes division by zero on test file for T79190.Jun 23 2021, 9:22 AM
William Leeson (leesonw) updated this revision to Diff 38648.Jun 23 2021, 9:39 AM

Moved the following variables: { use_lamp_mis, light_index } outside the test for zero lights as they are used in other places.

Philipp Oeser (lichtwerk) added a task: T89379: Fixes division by zero on test file for T79190.Jun 23 2021, 11:31 AM
Richard Antalik (ISS) edited tasks, added T79190: Cycles PMJ adaptive sampling working poorly with many bounces; removed T89379: Fixes division by zero on test file for T79190.Jun 23 2021, 12:06 PM
Brecht Van Lommel (brecht) requested changes to this revision.Jun 23 2021, 1:37 PM
Brecht Van Lommel (brecht) added inline comments.
intern/cycles/render/light.cpp
438–439

Some odd indentation here.

If you have clang-format set up on file save, it should correct that automatically.

This revision now requires changes to proceed.Jun 23 2021, 1:37 PM
William Leeson (leesonw) updated this revision to Diff 38695.Jun 24 2021, 9:00 AM

I have applied the clang-formating now (sorry I had missed this earlier).

William Leeson (leesonw) updated this revision to Diff 38705.Jun 24 2021, 3:00 PM

Removed some extra whitespace.

Brecht Van Lommel (brecht) accepted this revision.Jun 24 2021, 4:54 PM
This revision is now accepted and ready to land.Jun 24 2021, 4:54 PM
William Leeson (leesonw) mentioned this in T79190: Cycles PMJ adaptive sampling working poorly with many bounces.Jul 10 2021, 12:04 AM
Closed by commit rB5eed7cdc8c17: Division by zero when there are no lights and only emissive surfaces (authored by William Leeson (leesonw)). · Explain WhySep 6 2021, 1:20 PM
This revision was automatically updated to reflect the committed changes.
William Leeson (leesonw) added a commit: rB5eed7cdc8c17: Division by zero when there are no lights and only emissive surfaces.
Brecht Van Lommel (brecht) added a commit: rCfaf8f5f353fc: Division by zero when there are no lights and only emissive surfaces.Jan 27 2022, 11:28 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
render/
60 lines

Diff 38646

View Options

intern/cycles/render/light.cpp

Loading...