macOS: convert native OS window coordinate for Input Method
ClosedPublic
Actions

Authored by Yuki Hashimoto (hzuika) on Jun 24 2021, 10:42 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB2d0b9faaf6ec: Fix: IME conversion candidate window not correctly placed on macOS

Summary

This patch is a continuation of D11695 but this patch is independent.

Blender need to tell the input method program where the conversion candidate window is during Japanese and Chinese input.
In macOS, there are displays where the window size and the native pixel size are different, so the candidate window may appear in an unnatural position.

This patch converts the cursor position x and y for matching macOS window coordinate.

On Windows, GHOST_GetNativePixelSize returns 1, so it has no effect.

Diff Detail

Repository: rB Blender

Event Timeline

Yuki Hashimoto (hzuika) requested review of this revision.Jun 24 2021, 10:42 PM

Yuki Hashimoto (hzuika) created this revision.

Harbormaster completed remote builds in B15419: Diff 38734.Jun 24 2021, 10:42 PM

Yuki Hashimoto (hzuika) retitled this revision from macOS: use native pixel size to macOS: use native pixel size for IME candidate window.Jun 24 2021, 10:50 PM

Yuki Hashimoto (hzuika) edited the summary of this revision. (Show Details)

Yuki Hashimoto (hzuika) added a reviewer: Brecht Van Lommel (brecht).

Yuki Hashimoto (hzuika) added projects: Platform: macOS, User Interface.

Yuki Hashimoto (hzuika) mentioned this in D11695: macOS: support Japanese input for text buttons.Jun 25 2021, 1:04 AM

Yuki Hashimoto (hzuika) mentioned this in D11699: macOS: support Chinese and Korean input.Jun 25 2021, 2:08 AM

Convert to native OS window coordinates.

I changed to avoid redundant calculation in GHSOT.

Harbormaster completed remote builds in B15464: Diff 38848.Jun 28 2021, 4:45 PM

Yuki Hashimoto (hzuika) retitled this revision from macOS: use native pixel size for IME candidate window to macOS: convert native OS window coordinate for Input Method.Jun 28 2021, 4:49 PM

Yuki Hashimoto (hzuika) edited the summary of this revision. (Show Details)

Brecht Van Lommel (brecht) accepted this revision.Jul 5 2021, 1:16 PM

This revision is now accepted and ready to land.Jul 5 2021, 1:16 PM

Closed by commit rB2d0b9faaf6ec: Fix: IME conversion candidate window not correctly placed on macOS (authored by Yuki Hashimoto (hzuika), committed by Brecht Van Lommel (brecht)). · Explain WhyJul 5 2021, 2:33 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB2d0b9faaf6ec: Fix: IME conversion candidate window not correctly placed on macOS.