Differential D11698

Compositor: Full frame Viewer node
ClosedPublic
Actions

Authored by Manuel Castilla (manzanilla) on Jun 25 2021, 12:40 AM.

Details

Reviewers

Jeroen Bakker (jbakker)

Commits

rB300fe84bf0ad: Compositor: Full frame Viewer node

Summary

Adds full frame implementation to this node operation.
No functional changes.
No performance changes.

Diff Detail

Repository

rB Blender

Branch

cmp-node-viewer (branched from master)

Build Status

Buildable 15628
Build 15628: arc lint + arc unit

Event Timeline

Manuel Castilla (manzanilla) requested review of this revision.Jun 25 2021, 12:40 AM

Manuel Castilla (manzanilla) created this revision.

Harbormaster completed remote builds in B15423: Diff 38738.Jun 25 2021, 12:40 AM

Manuel Castilla (manzanilla) added a reviewer: Jeroen Bakker (jbakker).Jun 25 2021, 12:41 AM

Manuel Castilla (manzanilla) added a project: Compositing.

Manuel Castilla (manzanilla) mentioned this in T88150: Full Frame Compositor.Jun 29 2021, 11:34 PM

Manuel Castilla (manzanilla) added a child revision: D11783: [WIP] Compositor: Add position to operations.Jul 2 2021, 2:54 AM

Jeroen Bakker (jbakker) requested changes to this revision.Jul 5 2021, 9:14 AM

Jeroen Bakker (jbakker) added inline comments.

source/blender/compositor/operations/COM_ViewerOperation.cc
181	Not sure about this one. One thread can remove data that another thread is using.

This revision now requires changes to proceed.Jul 5 2021, 9:14 AM

For clarity use MemoryBuffer only when needed

Harbormaster completed remote builds in B15628: Diff 39181.Jul 6 2021, 12:38 AM

In this case MemoryBuffer is only a wrapper because it has not created the raw buffer. Doesn't delete it.

Manuel Castilla (manzanilla) marked an inline comment as done.Jul 7 2021, 1:41 PM

Jeroen Bakker (jbakker) accepted this revision.Jul 19 2021, 10:08 AM

This revision is now accepted and ready to land.Jul 19 2021, 10:08 AM

Closed by commit rB300fe84bf0ad: Compositor: Full frame Viewer node (authored by Manuel Castilla (manzanilla)). · Explain WhyJul 19 2021, 10:07 PM

This revision was automatically updated to reflect the committed changes.

Manuel Castilla (manzanilla) added a commit: rB300fe84bf0ad: Compositor: Full frame Viewer node.

Revision Contents
Changeset List

Path

Size

source/

blender/

compositor/

operations/

COM_ViewerOperation.h

12 lines

COM_ViewerOperation.cc

32 lines

Diff 39181

View Options

source/blender/compositor/operations/COM_ViewerOperation.h