Paths

Table of Contentst

Differential D1169

Python access to removing a shapekey
AbandonedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Mar 9 2015, 4:38 PM.

Tags

Subscribers

Campbell Barton (campbellbarton)

Sergey Sharybin (sergey)

Details

Reviewers

Philipp Oeser (lichtwerk)
Sergey Sharybin (sergey)

Maniphest Tasks

T41855: Python API: Object.shape_key_remove

Summary

This has been mentioned TODO
and also as TODO T41855: Python API: Object.shape_key_remove

Diff Detail

Event Timeline

Philipp Oeser (lichtwerk) updated this revision to Diff 3709.Mar 9 2015, 4:38 PM

Philipp Oeser (lichtwerk) retitled this revision from to Python access to removing a shapekey.

Philipp Oeser (lichtwerk) updated this object.

Philipp Oeser (lichtwerk) added projects: Add-ons (BF-Blender), BF Blender.

Philipp Oeser (lichtwerk) mentioned this in T41855: Python API: Object.shape_key_remove.Mar 9 2015, 4:41 PM

Philipp Oeser (lichtwerk) added a task: T41855: Python API: Object.shape_key_remove.

Sergey Sharybin (sergey) requested changes to this revision.Mar 11 2015, 11:54 AM

Sergey Sharybin (sergey) added a reviewer: Sergey Sharybin (sergey).

Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).

Sergey Sharybin (sergey) added inline comments.

source/blender/makesrna/intern/rna_object_api.c
247	use context only when it's really needed. Here you can pass `bmain` by using `FUNC_USE_MAIN` flag.
265	Use `WM_main_add_notifier()` instead.

This revision now requires changes to proceed.Mar 11 2015, 11:54 AM

Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).Mar 11 2015, 12:00 PM

Campbell Barton (campbellbarton) added inline comments.

source/blender/blenkernel/intern/object.c
3524–3532	This makes sense for the UI, but from API we may want a way to remove all keys in one step.
source/blender/makesrna/intern/rna_object_api.c
268	Yes this is need, so access after wont crash from accessing freed memory.

(thanx for having a look!)

adressed review by @Sergey Sharybin (sergey)
addressed review by @Campbell Barton (campbellbarton) [except comment about removing all keys in one step -- see inline comment...]

update to current master

Campbell Barton (campbellbarton) mentioned this in rB87629b2a7443: RNA: Object.shape_key_remove method.Jun 8 2015, 11:53 AM

Pushed rB87629b2a7443f1b2bf41062aec5054ab1123ca83

Campbell Barton (campbellbarton) abandoned this revision.Jun 8 2015, 11:53 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

1 line

intern/

57 lines

editors/

object/

object_shapekey.c

52 lines

makesrna/

intern/

rna_object_api.c

34 lines

Diff 3709

source/blender/blenkernel/BKE_object.h

Loading...

source/blender/blenkernel/intern/object.c

Loading...

source/blender/editors/object/object_shapekey.c

Loading...

source/blender/makesrna/intern/rna_object_api.c

Loading...