Fix name of UI emboss RNA enum item
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jun 25 2021, 5:59 AM.

Details

Reviewers

Commits

rB0afe4e81cbb2: Fix name of UI emboss RNA enum item

Summary

This was a stupid mistake in my original commit that added this item.
While this is an API breakage, the name is simply wrong, and it is only
6 months old, and slightly niche.

Diff Detail

Repository

rB Blender

Branch

ui-emboss-none-or-status-rna-name (branched from master)

Build Status

Buildable 15428
Build 15428: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jun 25 2021, 5:59 AM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B15428: Diff 38746.Jun 25 2021, 5:59 AM

Hans Goudey (HooglyBoogly) added a project: User Interface.Jun 25 2021, 5:59 AM

Hans Goudey (HooglyBoogly) mentioned this in T89350: Color indicating animation status missing from many icon buttons (all defined with emboss=False).Jun 25 2021, 3:59 PM

Have you grepped through the add-ons too?
Seems reasonable to me. Just make sure the breakage is mentioned in the release notes.

This revision is now accepted and ready to land.Jun 25 2021, 5:50 PM

Yeah, it wasn't used anywhere I could find luckily. Will do.

Closed by commit rB0afe4e81cbb2: Fix name of UI emboss RNA enum item (authored by Hans Goudey (HooglyBoogly)). · Explain WhyJun 28 2021, 4:53 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB0afe4e81cbb2: Fix name of UI emboss RNA enum item.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

properties_data_mesh.py

2 lines

source/

blender/

makesrna/

intern/

rna_ui.c

2 lines

Diff 38746

View Options

release/scripts/startup/bl_ui/properties_data_mesh.py