Simplify Blender ID registration
ClosedPublic
Actions

Authored by Anna Sirota (railla) on Jun 25 2021, 5:51 PM.

Details

Reviewers

Francesco Siddi (fsiddi)

Maniphest Tasks

T86495: Simplify Blender ID registration

Summary

Instead of requiring email verification before logging in, allow setting the password during registration and log in right away.
Score-based reCAPTCHA is used in the form to deter obvious abuse.

This allows redirecting right back to Blender Cloud /join without interrupting the subscription flow, see the video from the local dev server:

Deployment checklist

reCAPTCHA credentials must be copied to Sintel before this can be deployed

Diff Detail

Repository: rBID Blender ID

Event Timeline

Anna Sirota (railla) requested review of this revision.Jun 25 2021, 5:51 PM

Anna Sirota (railla) created this revision.

Anna Sirota (railla) added a task: T86495: Simplify Blender ID registration.

Anna Sirota (railla) edited the summary of this revision. (Show Details)Jun 25 2021, 5:53 PM

Anna Sirota (railla) added inline comments.Jun 25 2021, 6:13 PM

bid_api/views/create_user.py
39–40	Just moving the already existing nickname generation elsewhere to make it reusable in the new registration flow, which no longer requires a nickname.
bid_main/templates/bid_main/login.html
34	This change is important, this is the goal of the simplification, allowing people to register and end up where they started (e.g., Blender Cloud subscription checkout).
blenderid/oauth2_urls.py
15	Email confirmation is no longer enforced on login, hence the custom view is no longer used here.

Anna Sirota (railla) added a reviewer: Francesco Siddi (fsiddi).Jun 28 2021, 11:08 AM

Anna Sirota (railla) updated this revision to Diff 38828.Jun 28 2021, 11:34 AM

Anna Sirota (railla) added inline comments.

bid_main/templatetags/forms.py
9	`RegistrationForm` cannot use `BootstrapModelFormMixin` because it has to override `__init___` in its own way, so this filter is used to do the same thing `BootstrapModelFormMixin` does, but directly in the template. (It's worth completely replacing `BootstrapModelFormMixin` with this filter, for the sake of separating "business logic" from representation, however this is out of scope of this patch.)