Details

Reviewers

Commits

rB19da434e9cc0: Nodes: Improvements to edge panning in the node editor.

Summary

New operator property to toggle edge panning in the keymap: This is disabled by default to avoid edge-panning in cases where it gets distracting, such as adding a new node. Only the explicit translate operator(s) (GKEY or drag) have this enabled now.

Restore the initial view rect on edge pan cancel: The initial view rect is now stored in the edge pan operator data. When an operator with edge panning is cancelled it can now call the UI_view2d_edge_pan_cancel function to restore the original View2D rect.

Zero delay in node editor scrolling: Delay is useful when scrolling through long lists, such as in the outliner, but makes node scrolling feel sluggish and unresponsive. The lower scroll speed here makes a fast response the better option.

Zoom influence feature: Somewhat slower scrolling in UI-space when zoomed out. With the 0.5 zoom influence factor nodes behave as if zoom factor is halved, otherwise it gets too fast when zoomed out. Previously scrolling would always be constant-speed in UI space, now it's half-way between UI space and node (view) space.

Diff Detail

Repository

rB Blender

Branch

node-scrolling-improvements

Build Status

Buildable 16593
Build 16593: arc lint + arc unit

Event Timeline

Lukas Tönne (lukastoenne) requested review of this revision.Jun 29 2021, 1:38 PM

Lukas Tönne (lukastoenne) created this revision.

Harbormaster completed remote builds in B15483: Diff 38886.Jun 29 2021, 1:38 PM

Rahul Chaudhary (RC12) awarded a token.Jun 29 2021, 2:24 PM

Only reset the node view when links are cancelled.

Harbormaster completed remote builds in B15498: Diff 38913.Jun 29 2021, 6:18 PM

Lukas Tönne (lukastoenne) planned changes to this revision.Jun 29 2021, 6:18 PM

Lukas Tönne (lukastoenne) added a reviewer: Hans Goudey (HooglyBoogly).

Lukas Tönne (lukastoenne) requested review of this revision.Jun 29 2021, 6:21 PM

I've tested settings with zero "delay" on the scrolling, which feels quite nice and reactive. Also slightly slower speed here:

#define NODE_EDGE_PAN_MAX_SPEED 30 /* In UI units per second, slower than default. */
#define NODE_EDGE_PAN_DELAY 0.0f

Zero delay in node editor scrolling.

Himanshi Kalra (calra) added a subscriber: Himanshi Kalra (calra).Jul 1 2021, 9:53 AM

Zoom influence factor for edge scroll speed.

This allows modifying the scroll speed based on the View2D zoom factor.
With influence 0.0 (default behavior) the speed will be constant in
UI space as before.
At maximum influence 1.0 the speed will instead max out in the view
space, i.e. scrolls slower in UI space when zooming out.
At intermediate values the zoom influence is proportionally reduced,
for example at influence 0.5 the view will scroll as if zoom factor is
half of the actual zoom.

This feature is used in the node editor to slow down scrolling a bit
when zoomed out.

Harbormaster completed remote builds in B15537: Diff 39001.Jul 1 2021, 11:33 AM

Increase default node scroll speed again.

With the zoom influence feature the max speed at default zoom can be
increased again.

Harbormaster completed remote builds in B15556: Diff 39038.Jul 2 2021, 8:11 AM

Charlie Jolly (charlie) mentioned this in T86749: Geometry Node Community Additions.Jul 7 2021, 6:06 PM

Lukas Tönne (lukastoenne) retitled this revision from Improvements to edge panning in the node editor. to Nodes: Improvements to edge panning in the node editor..Jul 9 2021, 9:12 AM

Lukas Tönne (lukastoenne) edited the summary of this revision. (Show Details)

Hmm, testing this I like all of the changes except for the removal of the delay. Without it, I find the panning feels robotic, instant, and too often makes big changes when I just want to move the view slightly. It loses the subtlety and elegance it had before.

Obviously this is going to be somewhat subjective, and that's just my opinion. But I wonder if we would want to try committing this without the change to the delay and see how that does.

Without it, I find the panning feels robotic, instant, and too often makes big changes when I just want to move the view slightly. It loses the subtlety and elegance it had before.

Obviously this is going to be somewhat subjective, and that's just my opinion. But I wonder if we would want to try committing this without the change to the delay and see how that does.

I like it instant and robotic. To me it just feels sluggish with delay. What do we do now.

Added back some of the delay in node edge panning.

Harbormaster completed remote builds in B15869: Diff 39628.Jul 16 2021, 8:55 AM

In the interest of getting this patch finished i've added back some of the delay for smooth scrolling. It's faster than the previous value, so please check if that works for you.

Yuro (Yuro) awarded a token.Jul 18 2021, 1:21 PM

Sorry for the delay. I'm sorry to be picky, but after testing for a while I find 0.4 or 0.5 much better for the delay. Maybe we could get another opinion? @Pablo Vazquez (pablovazquez), do you have a moment to test this patch with different values for NODE_EDGE_PAN_DELAY?

release/scripts/presets/keyconfig/keymap_data/blender_default.py
1912–1915	I think this should use the other notation, like `transform.translate`

Merge branch 'master' into node-scrolling-improvements
Bump scroll delay in node editor up to 0.5 seconds.

Harbormaster completed remote builds in B16593: Diff 41049.Aug 24 2021, 10:16 AM

Increased the delay to 0.5 seconds now.

release/scripts/presets/keyconfig/keymap_data/blender_default.py
1912–1915	This does not appear to work, it looks like the properties list for nested macro operators expects names in the "TRANSFORM_OT_translate" format.

Thanks, this seems good to go now.

release/scripts/presets/keyconfig/keymap_data/blender_default.py
1912–1915	Ah, sorry. I figured it would be consistent here.

This revision is now accepted and ready to land.Aug 24 2021, 4:06 PM

Lukas Tönne (lukastoenne) closed this revision.Aug 24 2021, 7:01 PM

Lukas Tönne (lukastoenne) added a commit: rB0b295e886e73: Improvements to edge panning in the node editor..

Lukas Tönne (lukastoenne) edited commits, added rB19da434e9cc0: Nodes: Improvements to edge panning in the node editor.; removed rB0b295e886e73: Improvements to edge panning in the node editor..

Paul Larson (GeorgiaPacific) added a subscriber: Paul Larson (GeorgiaPacific).Aug 24 2021, 7:18 PM

Robert Windefjord (Robonnet) awarded a token.Sep 12 2021, 12:49 PM

Hans Goudey (HooglyBoogly) mentioned this in D13005: Fix T92427: Adding nodes does no edge-scrolling.Oct 26 2021, 2:48 PM

Nodes: Improvements to edge panning in the node editor.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 41049

release/scripts/presets/keyconfig/keymap_data/blender_default.py

source/blender/editors/include/ED_node.h

source/blender/editors/include/ED_transform.h

source/blender/editors/include/UI_view2d.h

source/blender/editors/interface/view2d_edge_pan.c

source/blender/editors/space_node/node_geometry_attribute_search.cc

source/blender/editors/space_node/node_relationships.cc

source/blender/editors/transform/transform.h

source/blender/editors/transform/transform.c

source/blender/editors/transform/transform_convert_node.c

source/blender/editors/transform/transform_generics.c

source/blender/editors/transform/transform_ops.c

Nodes: Improvements to edge panning in the node editor.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41049

release/scripts/presets/keyconfig/keymap_data/blender_default.py

source/blender/editors/include/ED_node.h

source/blender/editors/include/ED_transform.h

source/blender/editors/include/UI_view2d.h

source/blender/editors/interface/view2d_edge_pan.c

source/blender/editors/space_node/node_geometry_attribute_search.cc

source/blender/editors/space_node/node_relationships.cc

source/blender/editors/transform/transform.h

source/blender/editors/transform/transform.c

source/blender/editors/transform/transform_convert_node.c

source/blender/editors/transform/transform_generics.c

source/blender/editors/transform/transform_ops.c

Nodes: Improvements to edge panning in the node editor.
ClosedPublic
Actions

Revision Contents
Changeset List