Fix loading of indexed .bmp files
AbandonedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Mar 10 2015, 3:31 PM.

Details

Reviewers

rdb (rdb)
Sergey Sharybin (sergey)

Summary

This patch fixes some issues with loading of indexed BMP files.
(1) It used an invalid offset to determine where the BMP data starts. This information is provided by the file info header, which was previously ignored entirely.
(2) It read from the palette as RGB even though it really contains BGR data.
(3) It did not support images of bit depths 1, 2 and 4. Some programs I worked with produce such images automatically when they notice that there are only a few colours in the image, so it would be nice if Blender supported this.

I can provide test .bmp files if needed.

Diff Detail

Event Timeline

rdb (rdb) updated this revision to Diff 3715.Mar 10 2015, 3:31 PM

rdb (rdb) retitled this revision from to Fix loading of indexed .bmp files.

rdb (rdb) updated this object.

rdb (rdb) set the repository for this revision to rB Blender.

rdb (rdb) added a project: Images & Movies.

Would be nice to have a set of files which fails to load, so we can test the changes and so.

Sergey Sharybin (sergey) added inline comments.Mar 11 2015, 11:07 AM

source/blender/imbuf/intern/bmp.c
209	That's a bit weird, `bitoffs` is already 0 as far as i can follow the if statement above.

I don't know how to upload a file to Differential (it tells me to "drag" it, but I don't use a graphical file manager, so I don't know where I'd drag it from).

I uploaded it here:
http://rdb.name/indexed-bmps.zip

Thanks!