Page MenuHome

macOS: execute permission for all users
AbandonedPublic

Authored by Ankit Meel (ankitm) on Jun 29 2021, 10:30 PM.

Details

Summary

Run chmod after all directories are made and files are copied.


https://builder.blender.org/download/experimental/ See tmp_T72605
It still needs some changes on builder to work
properly, but anything against the code here ?

Ref T72605

Diff Detail

Repository
rB Blender
Branch
tmp_T72605
Build Status
Buildable 15514
Build 15514: arc lint + arc unit

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Jun 29 2021, 10:30 PM
Ankit Meel (ankitm) created this revision.

I've been trying things in the branch tmp_T72605.

I ran the patch locally to investigate the permissions issues.

It only changes the executable on the blender file.
Then code sign will fail trying to update it.

jamesm-mpm-macos-bigsur-arm64-01 blender-vdev % ls -la install_release/Blender.app/Contents/MacOS 
total 506104
drwx------  3 blender  staff         96 Jun 30 09:19 .
drwx------  6 blender  staff        192 Jun 30 09:19 ..
---x--x--x  1 blender  staff  259123428 Jun 30 09:19 Blender

All folders need to be set with o775 and files to o664 that do not need execute permissions.

This is a good edge case for failing on code sign.

I will add in the smoke-test a simple CLI test before running the GUI smoke tests.
This will ensure catching any file mode issues.

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)

fix multiple issues.

The code here as of now should work.. I mean it sets the permission locally just fine (checked by setting a+rwx).
But buildbot build's permissions are still wrong..
Please see if something is wrong with creating the DMG/ copying the files.

Regarding the code sign failure, there was one more: existence of .cstemp files which caused a failure. So might want to add that too.

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)Jun 30 2021, 2:44 PM
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)
  • Explicitly remove write for o and g.
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)Jul 2 2021, 7:17 PM