Fix T43786: Cycles bake disregards Auto Smooth (vertex per-face normals)
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Mar 10 2015, 5:46 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Dalai Felinto (dfelinto)

Commits

rBS1cd4070e35fa: Fix T43786: Cycles bake disregards Auto Smooth (vertex per-face normals)
rB1cd4070e35fa: Fix T43786: Cycles bake disregards Auto Smooth (vertex per-face normals)

Summary

Added an utility function which performs vertex split based on the loop
normal so now backing API matches to what's happening in Cycles and BI
in terms of autosplit.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) updated this revision to Diff 3716.Mar 10 2015, 5:46 PM

Sergey Sharybin (sergey) retitled this revision from to Fix T43786: Cycles bake disregards Auto Smooth (vertex per-face normals).

Sergey Sharybin (sergey) added reviewers: Campbell Barton (campbellbarton), Dalai Felinto (dfelinto).

Sergey Sharybin (sergey) updated this object.

Sergey Sharybin (sergey) mentioned this in T43786: Cycles bake disregards Auto Smooth (vertex per-face normals).Mar 10 2015, 5:48 PM

I couldn't apply the patch using arc patch D1174 (Usage Exception: Unable to apply patch!) did you create it with arcanist?

I think your patch may remove the need for the following in object_bake_api.c:
"/* triangulating so BVH returns the primitive_id that will be used for rendering */"

I would like to test it, but I'm a bit short in time to manually applying the patch.

Ofcourse it's arc and the patch applies just fine here.

argh nevermind, I tried to apply the patch 117, this applies fine, I'll check later

Campbell Barton (campbellbarton) accepted this revision.Mar 18 2015, 4:04 PM

Campbell Barton (campbellbarton) edited edge metadata.

Campbell Barton (campbellbarton) added inline comments.

source/blender/blenkernel/intern/mesh.c
2168	Could use some comment as to what its doing. `/* split faces based on edge angle, matches behavior in ... blah blah ... */`
2189	convention is to use `poly++`, same for ~4 other uses in this function `num_new_verts`