Page MenuHome
Differential D11750

Compositor: Full frame Double Edge Mask node
ClosedPublic
Actions

Authored by Manuel Castilla (manzanilla) on Jun 29 2021, 11:20 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Commits
rBb848d5cdf5b6: Compositor: Full frame Double Edge Mask node
Summary

Adds full frame implementation to this node operations.
No functional changes.
No performances changes.

Diff Detail

Repository
rB Blender
Branch
cmp-node-double-edge-mask (branched from master)
Build Status
Buildable 15671
Build 15671: arc lint + arc unit

Event Timeline

Manuel Castilla (manzanilla) requested review of this revision.Jun 29 2021, 11:20 PM
Manuel Castilla (manzanilla) created this revision.
Harbormaster completed remote builds in B15507: Diff 38930.Jun 29 2021, 11:20 PM
Manuel Castilla (manzanilla) added a reviewer: Jeroen Bakker (jbakker).Jun 29 2021, 11:22 PM
Manuel Castilla (manzanilla) added a project: Compositing.
Manuel Castilla (manzanilla) mentioned this in T88150: Full Frame Compositor.Jun 29 2021, 11:34 PM
Jeroen Bakker (jbakker) requested changes to this revision.Jul 5 2021, 8:46 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/compositor/operations/COM_DoubleEdgeMaskOperation.cc
1417

Why not directly write to output.

Now it seems we copy it to a tmp buffer single threaded to copy it to the final buffer multi threaded.

This revision now requires changes to proceed.Jul 5 2021, 8:46 AM
Manuel Castilla (manzanilla) updated this revision to Diff 39271.Jul 7 2021, 1:39 PM
  • Merge branch 'master' into cmp-node-double-edge-mask
  • Write to output directly to avoid copying
Harbormaster completed remote builds in B15670: Diff 39271.Jul 7 2021, 1:39 PM
Manuel Castilla (manzanilla) marked an inline comment as done.Jul 7 2021, 1:40 PM
Manuel Castilla (manzanilla) updated this revision to Diff 39272.Jul 7 2021, 1:56 PM
  • Remove map in previous commit, there should only be one output buffer
Harbormaster completed remote builds in B15671: Diff 39272.Jul 7 2021, 1:56 PM
Jeroen Bakker (jbakker) accepted this revision.Jul 19 2021, 10:27 AM

Just a note: we normally write the todos as TODO(manzanilla): So we know who owns the todo.

This revision is now accepted and ready to land.Jul 19 2021, 10:27 AM
Closed by commit rBb848d5cdf5b6: Compositor: Full frame Double Edge Mask node (authored by Manuel Castilla (manzanilla)). · Explain WhyJul 19 2021, 10:07 PM
This revision was automatically updated to reflect the committed changes.
Manuel Castilla (manzanilla) added a commit: rBb848d5cdf5b6: Compositor: Full frame Double Edge Mask node.

Revision Contents
Changeset List

PathSize
source/
blender/
compositor/
operations/
12 lines
40 lines

Diff 39272

View Options

source/blender/compositor/operations/COM_DoubleEdgeMaskOperation.h

Loading...
View Options

source/blender/compositor/operations/COM_DoubleEdgeMaskOperation.cc

Loading...