Page MenuHome

Compositor: Full frame Mask node
ClosedPublic

Authored by Manuel Castilla (manzanilla) on Jun 29 2021, 11:21 PM.

Details

Summary

Adds full frame implementation to this node operations.
No functional changes.
No performance changes.

Diff Detail

Repository
rB Blender
Branch
cmp-node-mask (branched from master)
Build Status
Buildable 15508
Build 15508: arc lint + arc unit

Event Timeline

Manuel Castilla (manzanilla) requested review of this revision.Jun 29 2021, 11:21 PM
Manuel Castilla (manzanilla) created this revision.
Jeroen Bakker (jbakker) requested changes to this revision.Jul 5 2021, 8:40 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/compositor/operations/COM_MaskOperation.cc
180

Don't we need to cleat the buffer in this case?

This revision now requires changes to proceed.Jul 5 2021, 8:40 AM
source/blender/compositor/operations/COM_MaskOperation.cc
180

At method start it's cleared. Then if there is no handles it will be already cleared here. And if there is only 1, we don't want to clear that handle rasterization or averaging it. By looking at tiled implementation it should produce same results.

  • Merge branch 'master' into cmp-node-mask
  • Merge branch 'master' into cmp-node-mask
  • Use iterators and only clear buffer when there are no handles
Manuel Castilla (manzanilla) marked an inline comment as done.Jul 31 2021, 9:17 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/compositor/operations/COM_MaskOperation.cc
180

Not for this patch, but we could move this responsibility to the operator. If I understood correctly we could reduce unneeded clearing when we reuse or allocate the buffers. Normally you would overwrite the whole buffer.

This revision is now accepted and ready to land.Aug 2 2021, 8:47 AM
This revision was automatically updated to reflect the committed changes.