This makes texture sockets have a label by default. This can be changed
by adding the SOCK_HIDE_LABEL flag to the socket. With this change the
switch node now shows the labels "True" and "False" like for the other
types of sockets.
UI:
Details
Details
- Reviewers
Hans Goudey (HooglyBoogly) - Maniphest Tasks
- T89170: Switch Node: Texture sockets need to have False/True labels
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- texture_socket_label (branched from master)
- Build Status
Buildable 15521 Build 15521: arc lint + arc unit
Event Timeline
Comment Actions
I think you might have to do something like the string socket does currently with uiLayout *row = uiLayoutSplit(layout, 0.4f, false); to get the alignment to look nicer.
| source/blender/editors/space_node/drawnode.cc | ||
|---|---|---|
| 3615 | 0.4 is generally the standard for splits in the UI currently. I guess you used 0.3 because otherwise the buttons get squashed at the default node width? I wonder if it's worth it to differ here. | |
| source/blender/editors/space_node/drawnode.cc | ||
|---|---|---|
| 3615 | Yup, I tried 0.4f first and it didn't look good enough, so I went with 0.3f. If that is not Ok, we'd need to use a different function here to get a better layout. | |
Comment Actions
Committed with rBcd692c695462: Geometry Nodes: Add labels for switch node texture sockets (forgot the "Differential Revision" field)