Page MenuHome
Differential D11769

Geometry Nodes: Curve Primitive Line
ClosedPublic
Actions

Authored by Johnny Matthews (guitargeek) on Jun 30 2021, 11:51 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T89220: Curve Primitive Nodes
Commits
rB29d6750134c4: Geometry Nodes: Curve Primitive Line
Summary

This node creates a PolySpline line in one of 2 modes:

  • Line between 2 points
  • Start Point, Direction, and Length

Both modes create splines with only start and endpoints. A resample node can be used afterward to increase the point count.

Diff Detail

Repository
rB Blender

Event Timeline

Johnny Matthews (guitargeek) requested review of this revision.Jun 30 2021, 11:51 PM
Johnny Matthews (guitargeek) created this revision.
Arian (14AUDDIN) awarded a token.Jul 1 2021, 11:09 AM
Hans Goudey (HooglyBoogly) added a task: T89220: Curve Primitive Nodes.Jul 5 2021, 5:54 PM
Hans Goudey (HooglyBoogly) added a subscriber: Erindale (Erindale).Jul 5 2021, 5:57 PM

I think @Erindale (Erindale) mentioned that the direction input should not have distance units. I think I agree, it's more of a direction vector. It's the length input that gives it the length anyway.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 5 2021, 7:28 PM
Closed by commit rB29d6750134c4: Geometry Nodes: Curve Primitive Line (authored by Johnny Matthews (guitargeek), committed by Hans Goudey (HooglyBoogly)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB29d6750134c4: Geometry Nodes: Curve Primitive Line.
Hans Goudey (HooglyBoogly) added a comment.Jul 5 2021, 7:29 PM

Thanks! I made some changes when committing:

  • White space
  • Variable names (small changes)
  • "Point 1" "Point 2" -> "Start" "End"
Some User (someuser) awarded a token.Jul 5 2021, 9:13 PM
Charlie Jolly (charlie) mentioned this in T86749: Geometry Node Community Additions.Jul 7 2021, 6:11 PM

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
2 lines
source/
blender/
blenkernel/
2 lines
intern/
1 line
makesdna/
9 lines
makesrna/
intern/
27 lines
nodes/
1 line
1 line
1 line
geometry/
nodes/
145 lines

Diff 38986

View Options

release/scripts/startup/nodeitems_builtins.py

Loading...
View Options

source/blender/blenkernel/BKE_node.h

Loading...
View Options

source/blender/blenkernel/intern/node.cc

Loading...
View Options

source/blender/makesdna/DNA_node_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_nodetree.c

Loading...
View Options

source/blender/nodes/CMakeLists.txt

Loading...
View Options

source/blender/nodes/NOD_geometry.h

Loading...
View Options

source/blender/nodes/NOD_static_types.h

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_curve_primitive_line.cc

Loading...