Page MenuHome
Differential D1177

Fix T43694 - "Hair Clumps Point to Scene Center When Density is Texture-Controlled"
ClosedPublic
Actions

Authored by Krzysztof Rećko (chrisr) on Mar 12 2015, 8:29 PM.

Details

Reviewers
Lukas Tönne (lukastoenne)
Maniphest Tasks
T43694: Hair Clumps Point to Scene Center When Density is Texture-Controlled
Summary

Added some guards to prevent clumping to non existing particles. Also, adjusted threaded child path evaluation, so each child is evaluated once - previously virtual parents were done twice, which caused me some headache. Hope I didn't break anything in the process!

This fixes T43694

Diff Detail

Event Timeline

Krzysztof Rećko (chrisr) updated this revision to Diff 3732.Mar 12 2015, 8:29 PM
Krzysztof Rećko (chrisr) retitled this revision from to Fix T43694 - "Hair Clumps Point to Scene Center When Density is Texture-Controlled".
Krzysztof Rećko (chrisr) updated this object.
Krzysztof Rećko (chrisr) updated this object.
Krzysztof Rećko (chrisr) added subscribers: Lukas Tönne (lukastoenne), Zauber Paracelsus (zauberexonar).
Kévin Dietrich (kevindietrich) added a reviewer: Lukas Tönne (lukastoenne).Mar 13 2015, 1:38 AM
Kévin Dietrich (kevindietrich) updated this object.
Kévin Dietrich (kevindietrich) added a task: T43694: Hair Clumps Point to Scene Center When Density is Texture-Controlled.
Lukas Tönne (lukastoenne) accepted this revision.Mar 25 2015, 6:25 PM
Lukas Tönne (lukastoenne) edited edge metadata.

LGTM

You never know what happens with particles, but don't see particularly dangerous code here.

This revision is now accepted and ready to land.Mar 25 2015, 6:25 PM
Lukas Tönne (lukastoenne) mentioned this in rBd4ac58d04989: Fix T43694, by Krzysztof Rećko (chrisr), reviewed in D1177..Mar 25 2015, 6:37 PM
Lukas Tönne (lukastoenne) added a comment.Mar 25 2015, 6:39 PM

Thank you for the patch, i committed it to master.

Krzysztof Rećko (chrisr) closed this revision.Mar 25 2015, 6:40 PM
Lukas Tönne (lukastoenne) mentioned this in rBSd4ac58d04989: Fix T43694, by Krzysztof Rećko (chrisr), reviewed in D1177..Mar 26 2015, 8:10 PM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
2 lines
intern/
28 lines
2 lines
10 lines

Diff 3732

View Options

source/blender/blenkernel/BKE_particle.h

Loading...
View Options

source/blender/blenkernel/intern/particle.c

Loading...
View Options

source/blender/blenkernel/intern/particle_distribute.c

Loading...
View Options

source/blender/blenkernel/intern/particle_system.c

Loading...