Low priority patch, I was just wondering if this made sense to have
in this file.
Details
Details
- Reviewers
Jacques Lucke (JacquesLucke)
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- float3-parallel (branched from master)
- Build Status
Buildable 15533 Build 15533: arc lint + arc unit
Event Timeline
| source/blender/blenlib/BLI_float3.hh | ||
|---|---|---|
| 283 | Not sure why this function gets to lines instead of just two directions. A cheaper way to compute this is probably to check if dir1.x / dir2.x == dir1.y / dir2.y == dir1.z / dir2.z. You'd only want to do a single division and use multiplication for the other axis. Also this should use some epsilon. | |