MSVC: Enable variable shadow warnings
AbandonedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Jul 2 2021, 6:16 PM.

Details

Reviewers: None

Summary

WShadow is on for GCC and MSVC devs sometimes accidentally
add code emitting these warnings, since msvc does not warn
about this by default.

This patch enables the appropriate warnings, but it seems
to emit up quite a few warnings GCC somehow did not notice.

see P2228 for a list.

I don't necessarily need a code review it's more a of dicussion review

Do we want to enable this?
If so, can/should we tweak GCC to be more pro-active in this area

If we decide to land this, we should alteast resolve the outstanding
warnings before doing so.

Diff Detail

Repository

rB Blender

Branch

tmp_variable_shadow (branched from master)

Build Status

Buildable 15566
Build 15566: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) requested review of this revision.Jul 2 2021, 6:16 PM

Ray Molenkamp (LazyDodo) created this revision.

Harbormaster completed remote builds in B15566: Diff 39057.Jul 2 2021, 6:16 PM

Jacques Lucke (JacquesLucke) mentioned this in D11855: Fix variable shadow warnings.Jul 8 2021, 5:36 PM

I went over the list to see what cases it finds (see D11855).
Overall, I do think that these cases should be fixed and that the warning should be enabled. I wonder if we can easily disable the warning for headers in extern/.

I think it's better to exclude the check for extern, indeed. Otherwise I agree it's a good thing to enable.

On the back burner, i just lack the time right now for a cleanup this big.

archived to prepare for migration

Revision Contents
Changeset List

Path

Size

CMakeLists.txt

2 lines

Diff 39057

View Options

MSVC: Enable variable shadow warningsAbandonedPublicActions