Page MenuHome
Differential D11799

IME Cleanup: Unused GHOST_TEventImeData Member
ClosedPublic
Actions

Authored by Harley Acheson (harley) on Jul 4 2021, 4:11 AM.

Details

Reviewers
Ray Molenkamp (LazyDodo)
Commits
rB45bb6b836a21: IME Cleanup: Unused GHOST_TEventImeData Member
Summary

Removal of unused tmp member of GHOST_TEventImeData

This patch just removes an unused member of GHOST_TEventImeData - "tmp" of type GHOST_TUserDataPtr - which is never referenced nor used in any way.

Diff Detail

Repository
rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Jul 4 2021, 4:11 AM
Harley Acheson (harley) created this revision.
Harley Acheson (harley) added a reviewer: Campbell Barton (campbellbarton).Jul 4 2021, 4:40 AM
Yuki Hashimoto (hzuika) awarded a token.Jul 6 2021, 2:52 AM
Harley Acheson (harley) updated this revision to Diff 41437.Sep 4 2021, 12:16 AM
Harley Acheson (harley) edited the summary of this revision. (Show Details)

Updating to current state of master.

Harley Acheson (harley) updated this revision to Diff 45677.Dec 6 2021, 12:36 AM

Updating to current state of master.

Ray Molenkamp (LazyDodo) accepted this revision.Jan 11 2022, 8:59 PM
Ray Molenkamp (LazyDodo) added a subscriber: Ray Molenkamp (LazyDodo).

Even the commit that introduced rBe81d077c852f: Input Method Editor (IME) support for text buttons it isn't using the field, no need for this to be stuck in review for 6 months, just go ahead and axe that field.

This revision is now accepted and ready to land.Jan 11 2022, 8:59 PM
Harley Acheson (harley) removed a reviewer: Campbell Barton (campbellbarton).Jan 11 2022, 9:10 PM
Closed by commit rB45bb6b836a21: IME Cleanup: Unused GHOST_TEventImeData Member (authored by Harley Acheson (harley)). · Explain WhyJan 11 2022, 9:36 PM
This revision was automatically updated to reflect the committed changes.
Harley Acheson (harley) added a commit: rB45bb6b836a21: IME Cleanup: Unused GHOST_TEventImeData Member.

Revision Contents
Changeset List

PathSize
intern/
ghost/
2 lines

Diff 46922

View Options

intern/ghost/GHOST_Types.h

Loading...