Page MenuHome
Differential D1180

GHash - Add GTests
AbandonedPublic
Actions

Authored by Bastien Montagne (mont29) on Mar 13 2015, 1:21 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Sergey Sharybin (sergey)
Maniphest Tasks
T43766: GHash Improvements
Summary

Based on D1178 and D1179.

Not much to add here, this simply adds two test files for ghash, a real testing one and a performance testing one.

Diff Detail

Event Timeline

Bastien Montagne (mont29) updated this revision to Diff 3738.Mar 13 2015, 1:21 PM
Bastien Montagne (mont29) retitled this revision from to GHash - Add GTests.
Bastien Montagne (mont29) updated this object.
Bastien Montagne (mont29) added reviewers: Campbell Barton (campbellbarton), Sergey Sharybin (sergey).
Bastien Montagne (mont29) set the repository for this revision to rB Blender.
Bastien Montagne (mont29) added a project: BF Blender.
Bastien Montagne (mont29) mentioned this in D1181: GHash - add optional hash storage in entries.Mar 13 2015, 1:25 PM
Bastien Montagne (mont29) added a task: T43766: GHash Improvements.Mar 13 2015, 2:10 PM
Sergey Sharybin (sergey) accepted this revision.Mar 18 2015, 3:25 PM
Sergey Sharybin (sergey) edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 18 2015, 3:25 PM
Campbell Barton (campbellbarton) edited edge metadata.Mar 18 2015, 5:42 PM

LGTM, though words10k could go into its own header. (distracts a bit from the patch, perhaps other tests could use too).
(picky 120 line length words10k - P212)

Bastien Montagne (mont29) abandoned this revision.Mar 19 2015, 9:12 PM
Bastien Montagne (mont29) mentioned this in D1155: GHash enhancements..

Committed (with suggested changes, and without 'set operations' part of course) as rB2941b4ad9bd7ee8.

Thanks for the reviews.

Revision Contents
Changeset List

PathSize
tests/
gtests/
blenlib/
523 lines
448 lines
3 lines

Diff 3738

View Options

tests/gtests/blenlib/BLI_ghash_performance_test.cc

Loading...
View Options

tests/gtests/blenlib/BLI_ghash_test.cc

Loading...
View Options

tests/gtests/blenlib/CMakeLists.txt

Loading...